Add an add-on pipeline for collecting dwarfs from elfs #1068
Conversation
There was a problem hiding this comment.
This PR lacks context.
- Is it a duplicate of https://github.com/nexB/scancode.io/pull/819/files ?
- What's the goal of simply collecting dwarf to put on extra_data ?
- Missing changelog entry
- Missing pipeline documentation
- Should this pipeline be included with the default built-in ones?
There was a problem hiding this comment.
@TG1999 You haven't address my concerns:
- Is it a duplicate of https://github.com/nexB/scancode.io/pull/819/files ?
- What's the goal of simply collecting dwarf to put on extra_data ?
- hould this pipeline be included with the default built-in ones?
#819 was an early end to end prototype. We should reuse and inform the code here from this experiment alright and later close #819 unmerged |
We could start a contrib section? |
|
So #819 is actually doing the d2d and not the data collection. This is the data collection part |
TG1999
force-pushed
the
dwarfs_from_elfs
branch
from
2fdde80
to
4a3a0f8
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
There was a problem hiding this comment.
- Shouldn't we use the "ELF" case/syntax everywhere instead of "Elf"?
- Why are we reverting to an older version of python-inspector?
The code looks generally fine, but let me re-iter my concern about including those very specialized pipelines along the default ones.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
I think this is OK. We need these in first in and we can refactor code at a later stage. The general direction will be eventually to subsume these pipelines in larger binary and source symbols extraction pipelines and pipes. But we need to walk before we run! And if we do not have these handy in one place until then, we are wasting time with extra packaging and dependency management. |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
| @@ -1948,7 +1948,7 @@ def has_directory_content_fingerprint(self): | |||
|
|
|||
| def elfs(self): | |||
| """ | |||
| Resources that are ``files`` and their filetype starts with "elf" and | |||
| Resources that are ``files`` and their filetype starts with "ELF" and | |||
There was a problem hiding this comment.
This change is not correct, the string is still "elf"
| @@ -27,7 +27,7 @@ | |||
| from scanpipe.pipelines import Pipeline | |||
|
|
|||
|
|
|||
| class InspectElfBinaries(Pipeline): | |||
| class InspectELFBinaries(Pipeline): | |||
There was a problem hiding this comment.
You need to update the references to this as well.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Fixing aboutcode-org/purldb#260 (comment)
Create a PURL a service backed by new SCIO analysis pipelines that takes a PURL for a native binary package as an input, and returns the DWARF debug symbol compilation unit paths when available. This will specifically be worked out for Debian native binary packages.