Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prerelease inside the build?? #74

Closed
keshav-space opened this issue May 18, 2022 · 5 comments
Closed

prerelease inside the build?? #74

keshav-space opened this issue May 18, 2022 · 5 comments

Comments

@keshav-space
Copy link
Member

https://github.com/nexB/univers/blob/6ad300ea515f99ffaae8b6a160724c32f027b5c0/tests/data/composer_gitlab.json#L1852-L1854

How did we end up with prerelease inside the build?
We are using Semver for Composer and 2.0.13+0alpha isn't Semver.
Am I missing something?

@aalexanderr
Copy link

seems like a valid semver to me:
https://semver.org/

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>
                ```

@keshav-space
Copy link
Member Author

I know pre-release can have build, but can a build contain pre-release?

@aalexanderr
Copy link

I'm not sure I understand the question? Both release and pre-release are types of builds - they are just marked in regards to lifecycle of releases.

@keshav-space
Copy link
Member Author

I'm not sure I understand the question? Both release and pre-release are types of builds - they are just marked in regards to lifecycle of releases.

I meant that according to semver specifications <version core> "-" <pre-release> "+" <build> is a valid semve-version but <version core> "+" <build> "-" <pre-release> is not.

keshav-space pushed a commit that referenced this issue Aug 30, 2023
Pin Sphinx version to 6.2.1
@keshav-space
Copy link
Member Author

My bad 2.0.13+0alpha is a valid semver version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants