Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NPM prerelease caret range expression #120

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Handle NPM prerelease caret range expression #120

merged 3 commits into from
Sep 6, 2023

Conversation

keshav-space
Copy link
Member

@TG1999
Copy link
Member

TG1999 commented Sep 6, 2023

@keshav-space LGTM! please add some context in commit messages to highlight why we are handling the caret expression in a special manner.

@keshav-space
Handle npm caret range expression
38a5a73 
- Don't use `python-semanticversion` for parsing the npm caret range:
    it's returning incorrect vers range for the prerelease caret range expressions.
- Issue #117

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Fix npm_advisory test data
8bfc443 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Test npm pre-release caret range handling
da287b1 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Copy link
Member Author

@keshav-space LGTM! please add some context in commit messages to highlight why we are handling the caret expression in a special manner.

Thanks @TG1999, I have added the context along with the link to the original issue in the commit message.

TG1999
TG1999 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keshav-space keshav-space merged commit f28c4b0 into main Sep 6, 2023
11 checks passed
@keshav-space keshav-space deleted the 117-fix-npm-caret-range branch September 6, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TG1999 TG1999 TG1999 approved these changes

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NpmVeresionRange is giving incorrect version range sequence for prerelease caret range
2 participants
@keshav-space @TG1999