Ensure that VersionRange is immutable and hashable #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #20 We now ensure that a `version_constraints` attribute is a tuple Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Hritik14
force-pushed
the
20-hashable
branch
3 times, most recently
from
8026499
to
da3e2ed
Compare
converters are executed before __attrs_post_init__ thus we need to convert explicitly in __attrs_post_init__ See: https://www.attrs.org/en/stable/init.html#order-of-execution Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
|
@pombredanne Added another commit to resolve the error. Do have a look. |
Hritik14
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #20
We now ensure that a
version_constraintsattribute is a tupleSigned-off-by: Philippe Ombredanne pombredanne@nexb.com