Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated releases & CI #163

Closed
SamMousa opened this issue Aug 30, 2023 · 4 comments
Closed

Automated releases & CI #163

SamMousa opened this issue Aug 30, 2023 · 4 comments

Comments

@SamMousa
Copy link
Contributor

Hey! Very cool library!

I see that you've not yet set up github actions to for fully automated releases & tests.
Nowadays this is actually very simple and definitely worth it if you want to reduce your maintenance load.

You could look at this repo for some inspiration: https://github.com/collecthor/collecthor-file-browser
I'd be happy to set it up in a PR here as well.

Note: for this to work properly you will need to use proper commit messages following a standard documented here: https://www.conventionalcommits.org/en/v1.0.0/

Cheers

@SamMousa
Copy link
Contributor Author

@ts-thomas apologies for the rude ping. Do you have time to maintain this package? Is there any way in which the community or myself could help in terms of contributions?

If not that's also fine of course, but then we know to move ahead with our fork :-)

@ts-thomas
Copy link
Contributor

Hey Sam, sorry for the late answer. If you like you can set it up :)
Thanks a lot, Thomas

@SamMousa
Copy link
Contributor Author

Step 1: #185

I have not been able to get the build working with google closure compiler:

Start build .....

src/js/template.js:38:8: WARNING - [JSC_TYPE_MISMATCH] assignment
found   : Element
required: null
  38|         template = document.createElement('div');
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

There might be more modern "hip" alternatives to google's compiler.

@SamMousa
Copy link
Contributor Author

Closing this; we can continue in the relevant PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants