Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(providers): properly warn when using Twitter OAuth 2 #3784

Merged
merged 4 commits into from
Feb 2, 2022
Merged

fix(providers): properly warn when using Twitter OAuth 2 #3784

merged 4 commits into from
Feb 2, 2022

Conversation

balazsorban44
Copy link
Member

Fixes #3767

Reasoning 💡

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Feb 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022 •
edited
Loading

Codecov Report

Merging #3784 (7cf5bf6) into main (f20d679) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3784   +/-   ##
=======================================
  Coverage   13.03%   13.03%           
=======================================
  Files          92       92           
  Lines        1458     1458           
  Branches      391      393    +2     
=======================================
  Hits          190      190           
  Misses       1254     1254           
  Partials       14       14
Impacted Files Coverage Δ
src/core/lib/assert.ts 0.00% <0.00%> (ø)
src/lib/logger.ts 64.28% <ø> (ø)
src/providers/twitter.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20d679...7cf5bf6. Read the comment docs.

@balazsorban44 balazsorban44 mentioned this pull request Feb 2, 2022
Merged
@balazsorban44 balazsorban44 temporarily deployed to Preview February 2, 2022 02:22 Inactive
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

🎉 Experimental release published on npm!

npm i next-auth@0.0.0-pr.3784.6c986ac7
yarn add next-auth@0.0.0-pr.3784.6c986ac7

@balazsorban44 balazsorban44 merged commit a7d34f9 into main Feb 2, 2022
@balazsorban44 balazsorban44 deleted the fix/twitter-oauth-2-warning branch February 2, 2022 11:37
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
@mnphpexpert
fix(providers): properly warn when using Twitter OAuth 2 (nextauthjs#…
394a666 
…3784)

* fix(providers): properly warn when using Twitter OAuth 2

* refactor(providers): move Twitter OAuth2 warning to `assert`

* fix: use proper warning code

* refactor: only set boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Refers to `@auth/core` providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Twitter OAuth2 warning causing downgrade to OAuth1
2 participants
@balazsorban44 @codecov-commenter