feat: add wapmorgan/mp3info and id3parser #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
replace-id3parser-with-mp3info
branch
from
f3347b6
to
5cd42e6
Compare
7 tasks
kesselb
force-pushed
the
replace-id3parser-with-mp3info
branch
3 times, most recently
from
8bb9428
to
168131b
Compare
come-nc
reviewed
Jun 26, 2023
composer/installed.php
Outdated
Comment on lines
4
to
6
| 'pretty_version' => 'dev-master', | ||
| 'version' => 'dev-master', | ||
| 'reference' => 'b28af7ccf0bebff554672543fbbfe0e5d99968bd', | ||
| 'pretty_version' => '1.0.0+no-version-set', | ||
| 'version' => '1.0.0.0', | ||
| 'reference' => NULL, |
There was a problem hiding this comment.
That part looks weird, is that expected?
There was a problem hiding this comment.
Indeed.
COMPOSER_ROOT_VERSION=dev-master composer update wapmorgan/mp3info --no-dev made it work.
There was a problem hiding this comment.
My bad. I ran composer inside my docker container without git installed.
kesselb
force-pushed
the
replace-id3parser-with-mp3info
branch
3 times, most recently
from
fa64d1d
to
55d46d1
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
replace-id3parser-with-mp3info
branch
from
55d46d1
to
6d4a68e
Compare
come-nc
approved these changes
Jun 27, 2023
ChristophWurst
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forked getID3 to provide a library to only read MP3 files but nothing else.
Our primary use case is to use an embedded image as a preview.