Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace id3parser with mp3info #38498

Merged
merged 1 commit into from Jun 28, 2023
Merged

Replace id3parser with mp3info #38498

merged 1 commit into from Jun 28, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented May 28, 2023 •
edited by nickvergessen

Summary

We forked getID3 to provide a library to only read MP3 files but nothing else.
Our primary use case is to use an embedded image as a preview.

Mp3Info seems like a nice and lightweight replacement for getID3.

TODO

Checklist

@kesselb kesselb added this to the Nextcloud 28 milestone May 28, 2023
@kesselb kesselb self-assigned this May 28, 2023
@kesselb kesselb force-pushed the feat-replace-id3parser-with-mp3info branch 3 times, most recently from 8c32e9c to 4ed04e6 Compare June 1, 2023 18:25
@kesselb kesselb force-pushed the feat-replace-id3parser-with-mp3info branch from 4ed04e6 to 63ea2f9 Compare June 26, 2023 12:16
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 26, 2023
@szaimen szaimen requested review from a team, ArtificialOwl and Fenn-CS and removed request for a team June 26, 2023 12:21
@kesselb kesselb force-pushed the feat-replace-id3parser-with-mp3info branch from 63ea2f9 to e0eb1c3 Compare June 27, 2023 09:03
@ChristophWurst ChristophWurst marked this pull request as draft June 28, 2023 12:14
@ChristophWurst
Copy link
Member

Setting as draft to prevent accidental merges

@kesselb
feat: replace id3parser with mp3info
3757f39 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the feat-replace-id3parser-with-mp3info branch from e0eb1c3 to 3757f39 Compare June 28, 2023 12:59
@kesselb kesselb marked this pull request as ready for review June 28, 2023 12:59
@kesselb
Copy link
Contributor Author

kesselb commented Jun 28, 2023

Setting as draft to prevent accidental merges

Thanks! Updated the 3rdparty submodule and rebased.

@Fenn-CS Fenn-CS merged commit 0d9abed into master Jun 28, 2023
41 checks passed
@Fenn-CS Fenn-CS deleted the feat-replace-id3parser-with-mp3info branch June 28, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kesselb @ChristophWurst @Fenn-CS @come-nc