Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login dialog displayed after successful mtls auth #12997

Open
4 tasks done
pboguslawski opened this issue May 10, 2024 · 2 comments
Open
4 tasks done

Login dialog displayed after successful mtls auth #12997

pboguslawski opened this issue May 10, 2024 · 2 comments
Labels
bug feature: authentication Authentication or accounts related stable-3.29

Comments

@pboguslawski
Copy link

⚠️ Before posting ⚠️

  • This is a bug, not a question or an enhancement.
  • I've searched for similar issues and didn't find a duplicate.
  • I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
  • I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

  1. Use client cert to authentictate to nc.
  2. See dialog that asks for additional login (here example in Polish):
    image
  3. See mobile session present in web UI.

Expected behaviour

After successful authentication with client certificate, device should be authorized to use nc without any other confirmations, permissions, tokens, passwords.

Actual behaviour

Login dialog is shown as above.

Android version

up to date

Device brand and model

Stock or custom OS?

Stock

Nextcloud android app version

4.6

Nextcloud server version

28.0.4

Using a reverse proxy?

Yes

Android logs

No response

Server error logs

No response

Additional information

No response

@pboguslawski pboguslawski changed the title Login dialog displayed after succesfull mtls auth Login dialog displayed after successful mtls auth May 10, 2024
@ne20002
Copy link

ne20002 commented May 10, 2024

I'm not sure how I can read a user id from a client certificate. In my setup (see #12931) I would be happy to just get a client certificate checked correctly on the reverse proxy regardless of the user of the certificate.

Having the client certificate just to set a higher security level on the TLS connection would be enough.

@pboguslawski
Copy link
Author

pboguslawski commented May 10, 2024

I'm not sure how I can read a user id from a client certificate.

TLS may be terminated on reverse proxy or web server and user_saml may provide user id to nc from environment variable (set by Apache for example). No need to pass user id from client to server separately. If client must know user id for something, should query nc API for it.

@joshtrichards joshtrichards added feature: authentication Authentication or accounts related stable-3.29 labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: authentication Authentication or accounts related stable-3.29
Projects
None yet
Development

No branches or pull requests

3 participants