Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump work-runtime-ktx from 2.3.3 to 2.3.4 #5697

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Mar 20, 2020

Bumps work-runtime-ktx from 2.3.3 to 2.3.4.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @tobiasKaminsky.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Mar 20, 2020
@nextcloud-android-bot
Copy link
Collaborator

@AndyScherzinger
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/androidx.work-work-runtime-ktx-2.3.4 branch from 2e83886 to ff28ea5 Compare March 24, 2020 08:09
@nextcloud-android-bot
Copy link
Collaborator

@AndyScherzinger
Copy link
Member

@tobiasKaminsky please see https://www.kaminsky.me/nc-dev/android-lint/13275.html#LintError this update leads to a lint error (bug in lib/linter)

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/androidx.work-work-runtime-ktx-2.3.4 branch from ff28ea5 to 6e549bc Compare April 2, 2020 07:23
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/androidx.work-work-runtime-ktx-2.3.4 branch from 6e549bc to 9e3ad36 Compare April 2, 2020 11:49
@nextcloud-android-bot
Copy link
Collaborator

@AndyScherzinger
Copy link
Member

Lint Failure

../../../src/main/java/com/nextcloud/client/jobs/BackgroundJobManagerImpl.kt: Unexpected failure during lint analysis of BackgroundJobManagerImpl.kt (this is a bug in lint or one of the libraries it depends on)

Message: null cannot be cast to non-null type kotlin.Long

The crash seems to involve the detector androidx.work.lint.InvalidPeriodicWorkRequestIntervalDetector.
You can try disabling it with something like this:
    android {
        lintOptions {
            disable "InvalidPeriodicWorkRequestInterval"
        }
    }

Stack: TypeCastException:InvalidPeriodicWorkRequestIntervalDetector.visitConstructor(InvalidPeriodicWorkRequestIntervalDetector.kt:70)
←UElementVisitor$DelegatingPsiVisitor.visitNewExpression(UElementVisitor.kt:1099)
←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1063)
←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:198)
←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:48)
←KotlinUQualifiedReferenceExpression.accept(KotlinUQualifiedReferenceExpression.kt:27)
←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:47)
←KotlinUQualifiedReferenceExpression.accept(KotlinUQualifiedReferenceExpression.kt:27)

You can set environment variable LINT_PRINT_STACKTRACE=true to dump a full stacktrace to stdout.

@tobiasKaminsky
Copy link
Member

@dependabot rebase

Bumps work-runtime-ktx from 2.3.3 to 2.3.4.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/androidx.work-work-runtime-ktx-2.3.4 branch from 9e3ad36 to a7c7d8d Compare April 8, 2020 05:15
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13440.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

402

Lint

TypemasterPR
Warnings9494
Errors11

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky merged commit 2ae9b70 into master Apr 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the dependabot/gradle/androidx.work-work-runtime-ktx-2.3.4 branch April 8, 2020 05:53
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.12.0 milestone Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants