Implement Flow integration #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
force-pushed
the
feature/flow
branch
from
40d638e
to
0ea52a8
Compare
marcelklehr
force-pushed
the
feature/flow
branch
from
ed993f4
to
474da6b
Compare
blizzz
reviewed
Aug 27, 2020
| * @inheritDoc | ||
| */ | ||
| public function isAvailableForScope(int $scope): bool { | ||
| return true; |
There was a problem hiding this comment.
this also allows administrator to configure global rules for creating bookmarks. Is this intended?
There was a problem hiding this comment.
Yeah, I wasn't sure what the use case for this would be, but I thought it couldn't hurt.
There was a problem hiding this comment.
the parameter is one of the scope constants from IManager, SCOPE_ADMIN or SCOPE_USER. Some operations might be available for both scopes, others like running arbitrary scripts only for admins, because they could do anything, and others like posting to Talk is personal only as it is bound to the user who configured the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blizzz I'd like to add some events here, too, but I'm kinda at a loss on how I would go about that. I already expose events on the global dispatcher. Do I merge those with the flow events? Or are those different events? What would be the event subject? Can you guide me through this a little?