Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for today marker #1104

Closed
der-daniel opened this issue Feb 8, 2019 · 6 comments
Closed

Improvement for today marker #1104

der-daniel opened this issue Feb 8, 2019 · 6 comments

Comments

@der-daniel
Copy link
Member

Inspired by the Outlook calendar, I think we can improve the marker for today.
This is what it looks like in Outlook.

image

I hacked a little html and came up with this.

<td class="fc-day-top fc-fri fc-today " data-date="2019-02-08">
  <div class="fc-day-marker" style="background-color:#0082C9; width: inherit; height: 3px;">
    <span class="fc-day-number" style="font-weight: bold; color:#0082C9">8</span>
  </div>
</td>

image

What do you think?

For Frodo!

@georgehrke
Copy link
Member

We already improved the visibility of today in #850 :)
Did you see that already?

@georgehrke
Copy link
Member

I hacked a little html and came up with this.

As far as i can tell you only added css but didn't change the actual html structure, right?

@georgehrke
Copy link
Member

cc @skjnldsv @nextcloud/designers

@der-daniel
Copy link
Member Author

We already improved the visibility of today in #850 :)
Did you see that already?

Yes, but I don't like the circle thing. So it's more like a different proposal to the today marker.

I hacked a little html and came up with this.

As far as i can tell you only added css but didn't change the actual html structure, right?

Yes, I just edited it with Chrome dev tools. It's more a proposal than pull request :)

@jancborchardt
Copy link
Member

It does look very nice. :) However we don’t need 2 different colored "Today" markers.

  • The solution with the bar has the drawback that it could be confused for the cell above as it’s directly on the border. The circled date is inside the cell.
  • The solution with the circled date reflects also what we do in the datepicker for the selected date, which is nicely consistent style.

So while this is really nice work @der-daniel, the solution in #850 seems more fitting. But design help for Calendar is always welcome, please check out some of the other design issues 🙂 https://github.com/nextcloud/calendar/issues?q=is%3Aopen+is%3Aissue+label%3Adesign

@der-daniel
Copy link
Member Author

alrighty then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants