Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Talk room for booked appointments #3480

Closed
4 of 5 tasks
Tracked by #66
ChristophWurst opened this issue Sep 15, 2021 · 15 comments · Fixed by #4025
Closed
4 of 5 tasks
Tracked by #66

Create Talk room for booked appointments #3480

ChristophWurst opened this issue Sep 15, 2021 · 15 comments · Fixed by #4025
Assignees
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Appointments skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Sep 15, 2021

  • Talk OCP API server#29922
  • UI option to create talk room for every booked appointment
  • Back-end logic that creates the talk rooms

Acceptance criteria

Work packages

@ChristophWurst

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst ChristophWurst removed this from the v3.0.0 milestone Nov 26, 2021
@ChristophWurst ChristophWurst added the blocked This ticket or PR is blocked by another one label Nov 26, 2021
@ChristophWurst ChristophWurst added enhancement New feature request and removed enhancement-proposed labels Nov 29, 2021
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Dec 27, 2021
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels Jan 27, 2022
@ChristophWurst ChristophWurst removed the blocked This ticket or PR is blocked by another one label Feb 4, 2022
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Feb 18, 2022

UI option to create talk room for every booked appointment

@jancborchardt @nimishavijay where shall we put the option to create a Talk room? Originally I thought about just having a checkbox at the end of the appointment modal that says "[ ] Create Talk room for every booked appointment".

But there are also more advanced ways to do it. Do we also want to distinguish between in person meetings and Talk meetings?

Bildschirmfoto von 2022-02-18 10-24-31

Bildschirmfoto von 2022-02-18 10-27-28

Calendly for reference.

In that theme we could first offer a multiselect with two options

  • In person meeting
  • Talk meeting

When In person meeting is picked, the Location field shows, otherwise we hide it and fill it with the Talk URL.

@nimishavijay
Copy link
Member

Good idea to distinguish between virtual and in-person events!

Create Talk room for every booked appointment

These Talk rooms would stay in your list even after the meeting, no? Won't it make your list in Talk look cluttered?
I was wondering if it would make sense to give the option of having one Talk room for one appointment configuration, and that link is used for every one who books, they would be a guest for that duration.
For example, I create a room called "Coffee with Nim" and that is used for all the coffee calls
What do you think?

@ChristophWurst
Copy link
Member Author

Well yes the user will have to clean up their convos. We can't do that automatically because we don't know if they should be kept or not.

And I do not think we should recycle the room either because then every guest can see the previous guests, the call metadata, the chat messages and any local users who stayed in the convo.

@nimishavijay
Copy link
Member

Ah yes good point, even if guests leave the chat messages would be there.
I still think it is a good idea to let users enter their own meeting link if they wanted to use another platform, for eg. Jitsi.

I think we could just show all fields without making the user choose what type of meeting it is, it seems like just extra steps to me. So we could directly show the fields for:
Location, Meeting link and "[ ] Create a Talk room for every booked appointment"
If the location field is filled, then it would be in-person, if the meeting link is filled/Talk room is checked then it would be virtual, if both are filled then it's hybrid I guess.
Checking "Create a Talk room..." will probably disable the meeting link field because the rooms will be automatically created, I'd say.

What do you think? cc @jancborchardt for any further input

@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels May 20, 2022
@ChristophWurst ChristophWurst added skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills skill:backend Issues and PRs that require backend development skills labels Jul 16, 2022
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Oct 31, 2022
@ChristophWurst ChristophWurst self-assigned this Oct 31, 2022
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels Nov 30, 2022
@ChristophWurst ChristophWurst removed their assignment Dec 21, 2022
@thecyberd3m0n
Copy link

thecyberd3m0n commented Mar 10, 2023

I wonder if it will be done? As I need this feature for planning appointments. Can I help somehow to deliver this feature faster?

@rasos
Copy link

rasos commented Apr 4, 2023

Ideally an admin could set, which video conferencing platforms are offered, as suggested in #4192, and the user can choose a preference.

For jitsi based platforms the location creation even would not need any API call, just https://myjitsi.net/randomroomname

For BigBlueButton based platforms a room could be booked from the corresponding app littleredbutton/cloud_bbb#137

@miaulalala miaulalala removed their assignment Apr 4, 2023
@hamza221 hamza221 self-assigned this Apr 12, 2023
@ChristophWurst ChristophWurst added 2. developing Work in progress 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Appointments skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants