Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

month view no longer sorted chronologically #4443

Closed
nrgeen opened this issue Aug 25, 2022 · 26 comments · Fixed by #4646
Closed

month view no longer sorted chronologically #4443

nrgeen opened this issue Aug 25, 2022 · 26 comments · Fixed by #4646
Labels
4. to release Ready to be released and/or waiting for tests to finish blocked This ticket or PR is blocked by another one bug Feature: Fullcalendar

Comments

@nrgeen
Copy link

nrgeen commented Aug 25, 2022

Steps to reproduce

  1. Update to version 3.4.3.
  2. Open the month view in the calendar. Several calendars are visible.

Expected behavior

The appointments are displayed chronologically in the respective day.

Actual behaviour

Although the appointments are entered on the correct day and also with the correct time, the sorting is not comprehensible.

Calendar app version

3.4.3

CalDAV-clients used

No response

Browser

Firefox 104

Client operating system

Windows 11, Fedora 36

Server operating system

No response

Web server

Apache

Database engine version

MariaDB

PHP engine version

PHP 8.0

Nextcloud version

24.0.2

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response
@nrgeen nrgeen added 0. to triage Pending approval or rejection bug labels Aug 25, 2022
@simonjones49
Copy link

Same issue on Arch with PHP8.1

@tcitworld
Copy link
Member

Related to #4431 @st3iny ?

@st3iny
Copy link
Member

st3iny commented Aug 26, 2022

Yeah, that is a regression we had to take in order to fix a more severe visibility bug. We have to wait until the bug is fixed upstream in FullCalendar until we can revert the order changes again.

@st3iny st3iny added Feature: Fullcalendar blocked This ticket or PR is blocked by another one wontfix This will not be worked on and removed 0. to triage Pending approval or rejection labels Aug 26, 2022
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed wontfix This will not be worked on labels Aug 26, 2022
@ChristophWurst
Copy link
Member

Blocked by fullcalendar/fullcalendar#6608. We can close the ticket once the upstream ticket is resolved, released and brought into our app.

@tgly307

This comment was marked as duplicate.

Sign in to view
@mhazan01
Copy link

any workaround ? this is really upsetting

@st3iny
Copy link
Member

st3iny commented Aug 30, 2022

@mhazan01 See my and Christophs comment. There is nothing we can do right now.

@mhazan01
Copy link

any way to reverse to a prior version that didn't have that bug ?

@pm-pm
Copy link

pm-pm commented Aug 31, 2022

Why is there no WARNING before updating?

@dinosmm
Copy link

dinosmm commented Aug 31, 2022

Is this sorted in 3.5.0? It's not mentioned in the changelog that shows in the Nextcloud app page.

@ChristophWurst
Copy link
Member

There were no database migrations from 3.4.2 to 3.4.0 or event 3.5.0 https://github.com/nextcloud/calendar/compare/v3.4.3..v3.5.0 so you can go back to 3.4.2 if you prefer the previous state.

@moboter
Copy link

moboter commented Sep 2, 2022

Howto revert to previous app version
(assuming that the database structure hasnt changed)
Disable Calendar App in nextcloud
delete calendar from from nextcloud/apps/
Download previous version from
https://apps.nextcloud.com/apps/calendar/releases?platform=22#22
and extract it do nextcloud/apps/calendar
check folder permissions
aktivate calendar app

@moboter
Copy link

moboter commented Sep 2, 2022 •
edited
Loading

Also shared calendar entries are not grouped anymore in version 3.5.0

@JoshData JoshData mentioned this issue Sep 3, 2022
Merged
@JoshData

This comment was marked as off-topic.

Sign in to view
@ChristophWurst ChristophWurst mentioned this issue Sep 6, 2022
Closed
@smoebody
Copy link

smoebody commented Sep 8, 2022 •
edited
Loading

@mhazan01 See my and Christophs comment. There is nothing we can do right now.

The mentioned bug is almost a year old and no sign of being fixed soon whatsoever. I vote for a workaround in order to fix the regression. In my opinion the impact is to severe to wait for an undisclosed time period.

@ChristophWurst
Copy link
Member

Sure. What do you suggest as a workaround?

@smoebody
Copy link

smoebody commented Sep 8, 2022

From what I understand the issue related to #4431 the missing events only effect the week view. How about applying the eventOrder change from #4431 only in week view?

@ChristophWurst
Copy link
Member

That sounds worth a test!

@ximex

This comment was marked as duplicate.

Sign in to view
@Zulgrib

This comment was marked as off-topic.

Sign in to view
@moboter

This comment was marked as off-topic.

Sign in to view
@tcitworld tcitworld mentioned this issue Sep 30, 2022
Closed
@kb8cb40j1av39c02
Copy link

Like a month later and this is sadly still an issue. Luckily was able to downgrade my calendar to V3.4.2 and it's fixed now.
Are there plans already to fix the sorting in the latest version of calendar for nextcloud?

@ChristophWurst ChristophWurst mentioned this issue Oct 10, 2022
Closed
@miaulalala miaulalala mentioned this issue Oct 11, 2022
Closed
@tcitworld tcitworld mentioned this issue Oct 12, 2022
Closed
tcitworld added a commit that referenced this issue Oct 18, 2022
@tcitworld
Only add title to event order when we're using the week-view
5334250 
Closes #4443

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld mentioned this issue Oct 18, 2022
Merged
backportbot-nextcloud bot pushed a commit that referenced this issue Oct 18, 2022
@tcitworld @backportbot-nextcloud
Only add title to event order when we're using the week-view
e4bc96b 
Closes #4443

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
backportbot-nextcloud bot pushed a commit that referenced this issue Oct 18, 2022
@tcitworld @backportbot-nextcloud
Only add title to event order when we're using the week-view
3eaf485 
Closes #4443

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@dinosmm
Copy link

dinosmm commented Oct 19, 2022

Yay, thank you so much for fixing this!
Will this be available in 3.5.x or will it only be on 4.0.0 (which I assume means we have to wait for NC 25)?

@tcitworld
Copy link
Member

This has been backported to 4.0.1 (already released) and 3.5.x (not yet released).

@miaulalala miaulalala added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Oct 19, 2022
@st3iny
Copy link
Member

st3iny commented Oct 19, 2022

Keep in mind that we didn't fix the issue. We just applied the workaround proposed by @smoebody.

We have still have to wait for a proper upstream fix in FC to be able to fully revert my changes.

@mhazan01
Copy link

Thank you very much for implementing the workaround and updating the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish blocked This ticket or PR is blocked by another one bug Feature: Fullcalendar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only add title to event order when we're using the week-view nextcloud/calendar