Fix missing events in week view

[st3iny]

If there are too many events on the last day of a week (e.g. Sunday), some might be hidden when the "limit events per view" checkbox is checked.

There already is an ongoing upstream ticket at fullcalendar/fullcalendar#6608. The bug is not yet solved by the FC maintainers but there is a (dirty) quick fix available (ref fullcalendar/fullcalendar#6608 (comment)). Unfortunately, this fix introduces some visual regressions because it changes the ordering of events inside the view. Take a look at my screenshots below (basically events are primarily ordered by title now). If there is a proper solution/fix for the ticket we may revert our changes.

In my opinion, missing events are more severe than having a slightly different event order so I strongly recommend moving on with this.

Thanks to @miaulalala for helping me debug this and finding the mentioned issue.

Before

After

Visual regressions

Before

After

[codecov]

Codecov Report

Merging #4431 (b7b43f2) into main (dceecc8) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b7b43f2 differs from pull request most recent head c5b5f16. Consider uploading reports for the commit c5b5f16 to get more accurate results

@@             Coverage Diff              @@
##               main    #4431      +/-   ##
============================================
- Coverage     29.42%   29.40%   -0.02%     
  Complexity      330      330              
============================================
  Files           220      220              
  Lines          7702     7700       -2     
  Branches       1019     1017       -2     
============================================
- Hits           2266     2264       -2     
  Misses         5436     5436              

Flag	Coverage Δ
javascript	20.49% <ø> (-0.03%)	⬇️
php	68.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/CalendarGrid.vue	0.00% <ø> (ø)
src/fullcalendar/rendering/eventOrder.js	100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ChristophWurst]

In my opinion, missing events are more severe than having a slightly different event order so I strongly recommend moving on with this.

Agreed. @jancborchardt wdyt?

[st3iny]

/backport to stable3.4

[jancborchardt]

Sounds good – thanks for the explanation on the drawbacks. :)