Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add title to event order when we're using the week-view #4646

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Only add title to event order when we're using the week-view #4646

merged 1 commit into from
Oct 18, 2022

Conversation

tcitworld
Copy link
Member

Closes #4443

@tcitworld
Only add title to event order when we're using the week-view
5334250 
Closes #4443

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added the 3. to review Waiting for reviews label Oct 18, 2022
@tcitworld
Copy link
Member Author

/backport to stable4.0

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Oct 18, 2022
@tcitworld
Copy link
Member Author

/backport to stable3.5

@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 41.86% // Head: 41.86% // No change to project coverage 👍

Coverage data is based on head (5334250) compared to base (c31eee0).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4646   +/-   ##
=========================================
  Coverage     41.86%   41.86%           
  Complexity      348      348           
=========================================
  Files           226      226           
  Lines          5659     5659           
  Branches        738      738           
=========================================
  Hits           2369     2369           
  Misses         3290     3290
Flag Coverage Δ
javascript 31.42% <ø> (ø)
php 69.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/CalendarGrid.vue 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

st3iny
st3iny approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Thanks a lot for fixing this, Thomas.

@st3iny st3iny enabled auto-merge October 18, 2022 14:17
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 18, 2022
@st3iny st3iny merged commit e9424f7 into main Oct 18, 2022
@st3iny st3iny deleted the fix-event-order branch October 18, 2022 14:24
This was referenced Oct 18, 2022
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Oct 18, 2022
st3iny added a commit that referenced this pull request Feb 21, 2024
@st3iny
fix: restore original event ordering
b6476f6 
The underlying issue has been fixed upstream.

This reverts:
- c5b5f16 (#4431)
- 5334250 (#4646)

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny mentioned this pull request Feb 21, 2024
Merged
st3iny added a commit that referenced this pull request Mar 18, 2024
@st3iny
fix: restore original event ordering
ded1f29 
The underlying issue has been fixed upstream.

This reverts:
- c5b5f16 (#4431)
- 5334250 (#4646)

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

month view no longer sorted chronologically
2 participants
@tcitworld @st3iny