Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of bower #594

Closed
raimund-schluessler opened this issue Sep 11, 2017 · 8 comments
Closed

Get rid of bower #594

raimund-schluessler opened this issue Sep 11, 2017 · 8 comments
Assignees

Comments

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Sep 11, 2017

As the landing page of bower states, they recommend to use Yarn (+webpack) instead of bower. Since we already use gulp here, I propose to use Yarn + Gulp instead of bower.

I adjusted the build environment for the Tasks app already and everything works fine just without bower now. The only problem is, that the currently used datepicker is not available over NPM and also it's github repository cannot be used since it doesn't contain a package.json. The solution to this would be to check in the datepicker into the Calendar repository (or to use a different datepicker 😉).

If you want to, I can send a PR.

@georgehrke
Copy link
Member

We already talked about this in #540 :)

@raimund-schluessler
Copy link
Member Author

So... You want to use NPM5 over Yarn? Most comparisons I had a look on stated that Yarn is still faster than NPM5.

@tcitworld
Copy link
Member

However, npm is installed along with NodeJS, so I'm to get back with that. I don't bother much for a few milliseconds.
PR welcomed. :)

@raimund-schluessler
Copy link
Member Author

I will send a PR to remove bower, but I think switching back to npm should be a separate PR.

@georgehrke
Copy link
Member

Are the yarn and npm lock file compatible with each other?

I'd be very happy if we supported both. If yarn is installed on a user's system, use it.
Otherwise fall back to npm but still be fully functional.

@tcitworld
Copy link
Member

Are the yarn and npm lock file compatible with each other?

They are not. Discussion is here: yarnpkg/yarn#3614

@georgehrke
Copy link
Member

Hmm, in that case I would vote for npm. Yarn is yet another dependency someone has to install when they want to contribute to the calendar app. NPM comes by default with Node.js.

Earlier on we decided for yarn because npm4 was so terribly slow, but nowadays npm5 is *almost* as fast as yarn.

@georgehrke
Copy link
Member

Fixed by @tcitworld last week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants