Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with NC14 #215

Closed
rullzer opened this issue Jul 26, 2018 · 13 comments
Closed

Incompatible with NC14 #215

rullzer opened this issue Jul 26, 2018 · 13 comments

Comments

@rullzer
Copy link
Member

rullzer commented Jul 26, 2018

We needed to add some functions to the share provider interface.

For circles this means we should add those functions (even if they don't do anything for now). Else php does 💥

@juliusknorr
Copy link
Member

@daita

@ArtificialOwl
Copy link
Member

fixed next release.

@juliusknorr
Copy link
Member

@daita Is the patch public already? I'd like to do some fixes on the admin settings, but the app is broken on master atm.

@ArtificialOwl
Copy link
Member

I was just heading to the admin settings thing, but if you want to take care of it, please do.

I will release a branch with some other thing later today.

@juliusknorr
Copy link
Member

Yes I'll sure I'll to that once master so ready for 14 👍

@moblesmarti
Copy link

Error install circles:
{"reqId":"FdOvKsHlkuf6exRCxFBq","level":3,"time":"2018-09-08T13:56:51+02:00","remoteAddr":"XXX.XXX.X.XX","user":"admin","app":"PHP","method":"POST","url":"/login?redirect_url=/apps/files/","message":"Class OCA\Circles\ShareByCircleProvider contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\Share\IShareProvider::restore) at /var/www/nextcloud/apps/circles/lib/

@moblesmarti
Copy link

With the new version 0.15.0 the problem has been solved.
Thank you!

@moblesmarti
Copy link

Sorry! I apologize for my previous message. It can be installed but it still does not work correctly...
Class OCA\Circles\ShareByCircleProvider contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\Share\IShareProvider::restore) at /var/www/nextcloud/apps/circles/lib/ShareByCircleProvider.php#64

@ArtificialOwl
Copy link
Member

Can you confirm you have this line in lib/ShareByCircleProvider.php:

public function restore(IShare $share, string $recipient): IShare {

@moblesmarti
Copy link

If I confirm that it is.
With 0.15.1 we have been able to install the app but we can not add members.
Thanks!

@moblesmarti
Copy link

It does not allow adding members and I have also noticed that in the top menu there is no option to add groups and share
captura de pantalla 2018-09-10 a las 16 16 45

@moblesmarti
Copy link

He deleted and reinstalled the application and now it allows me to add mienbros...

@joshtrichards
Copy link
Member

Fixed in 934b4e1 and elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants