Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact image improvements #33

Closed
MariusBluem opened this issue Nov 16, 2016 · 7 comments
Closed

Contact image improvements #33

MariusBluem opened this issue Nov 16, 2016 · 7 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request

Comments

@MariusBluem
Copy link
Member

MariusBluem commented Nov 16, 2016

To improve the performance of the Nextcloud contacts, we should consider about the following:

  • Resize the Images when they are uploaded (for too large images)
  • Provide an editor to cut and resize images (see personal-settings)

Discussed with @schiessle and @nickvergessen

@MariusBluem MariusBluem added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request labels Nov 16, 2016
@skjnldsv
Copy link
Member

For information, the actual max size allowed is 1MB (f026e46)

@amittel
Copy link

amittel commented Feb 26, 2017

Just cleaned up my android contacts and transfered them to NC.
But finding a contact image (which are most of the time photos taken by my mobile) below 1MB is almost impossible.

So I'm asking if this issue is still current?

Right now I may just edit the hard-coded limit.
Would it be hard to transfer the code from personal-settings to contacts?

@nursoda
Copy link

nursoda commented Feb 27, 2017

Please also add an (editable?!) file size and/or image resolution WARNING limit.
I see two modes possible:

  • bigger effort to implement but ease of use:
    pictures are resized automatically if above any warning limit
  • less effort to implement but usable
    warn user to resize image(s) prior to uploading them

Interesting question is what should happen if a user saves an EXISTING contact that exceeds any limit.

BTW: in VCARD 3.0, there's also a LOGO: property which seems to be for company contacts without personal data. Would be nice to be able to use that, too, although I'm not sure which clients properly do support that.

@jancborchardt
Copy link
Member

cc @rullzer @icewind1991 @schiessle on this.

@sunjam
Copy link

sunjam commented Apr 12, 2018

@skjnldsv
Copy link
Member

skjnldsv commented Oct 2, 2018

Merging this into #106

@brettferrell
Copy link

Another idea to consider, if the email address is associated with a Gravatar account, default to that image.

https://en.gravatar.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants