Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not redownload the url-image #2259

Closed
Mannshoch opened this issue Apr 21, 2024 · 1 comment · Fixed by #2319
Closed

Do not redownload the url-image #2259

Mannshoch opened this issue Apr 21, 2024 · 1 comment · Fixed by #2319
Labels
Backend Issue or PR related to the backend code bug Something isn't working

Comments

@Mannshoch
Copy link

Description
If an URL is the base of a receip image and you edit it later. On save the Url try to redownload. If the image does not exist an error appear and you could not procceed.

Reproduction
Steps to reproduce the behavior:

  1. Go to a receip
  2. Click on edit something and save
  3. See error

Expected behavior
No redownload of the image if the URL not changed.

Actual behavior
If an URL is the base of a receip image and you edit it later. On save the Url try to redownload. If the image does not exist an error appear and you could not procceed.

Browser
Firefox

Versions
Nextcloud server version: 28.0.4
Cookbook version: 0.11.0

@Mannshoch Mannshoch added the bug Something isn't working label Apr 21, 2024
@christianlupus christianlupus added the Backend Issue or PR related to the backend code label May 16, 2024
@christianlupus
Copy link
Collaborator

@seyfeb with the upcoming changes in the frontend and the new class structure in the JS code, how is the URL of the image handled? Is it just kept as it is? I just want to avoid conflicts with the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Issue or PR related to the backend code bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants