Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger Thumbnails #406

Open
Teifun2 opened this issue Nov 22, 2020 · 5 comments
Open

Bigger Thumbnails #406

Teifun2 opened this issue Nov 22, 2020 · 5 comments
Labels
Backend Issue or PR related to the backend code enhancement New feature or request

Comments

@Teifun2
Copy link
Collaborator

Teifun2 commented Nov 22, 2020

Is your feature request related to a problem? Please describe.
Currently the image of a recipe is once scaled town and cut to a square to create a thumbnail. This Thumbnail has a very low resolution.

Describe the solution you'd like
For Apps or other Clients it would be great to have a wider variety of thumbnail Resolution, to suit different devices.

Describe alternatives you've considered
If we don't store higher resolution thumbnails we always need to download the full image for devices with a big resolution. This is traffic intensive but would work.

Related Issue on Android App:
Teifun2/nextcloud-cookbook-flutter#28

If it would be ok to do that, i could create an initial pull request to implement that.

@Teifun2 Teifun2 added the enhancement New feature or request label Nov 22, 2020
@christianlupus christianlupus added the Backend Issue or PR related to the backend code label Nov 23, 2020
@christianlupus
Copy link
Collaborator

If you want to take a first attempt, you are welcome to do so. There might be some changes soon (e.g. #340) but that will take some time until implemented. Just be aware to not put too much effort into it as it might get updated anyways.
Just assign yourself with this issue to mark it "in progress".

This was referenced Nov 24, 2020
@Teifun2
Copy link
Collaborator Author

Teifun2 commented Dec 6, 2020

Hmm the #340 Is very interesting.

It depends a little. Do you know how long it will take to incorporate these changes? If it is 1-2 Months i might wait for my changes but its something more like a year i probably will change it for the short term!

@seyfeb
Copy link
Collaborator

seyfeb commented Dec 6, 2020

@Teifun2 In #413, I implemented lazy-loading for thumbnails in the recipe lists. While already dealing with this stuff, I changed the default thumb size to 256x256. What resolution do you have in mind?

@Teifun2
Copy link
Collaborator Author

Teifun2 commented Dec 6, 2020

@seyfeb Oh wow thats great to hear! I think bigger thumbnails are always "better" ^^
I was thinking that we could maybe add different "sizes" and load on demand what fits best. But thats quite a lot of work!
I'm very happy if i have 256 images :D

@christianlupus
Copy link
Collaborator

We might want to define a set of sizes we want to have and create these in the background upon the implementation of #340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Issue or PR related to the backend code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants