Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collections #599

Open
m4lt3 opened this issue Feb 18, 2021 · 4 comments
Open

Add collections #599

m4lt3 opened this issue Feb 18, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@m4lt3
Copy link

m4lt3 commented Feb 18, 2021

I'd be very happy about a feature to create custom collections, in addition to categories and tags (e.g. "my favourite recipes" collection). This would make managing many recipes much easier.

Implementing this feature should just require a new table with a 1:n. connection between collections and recipes.

Currently the only way to group recipes this "randomly" would be by bookmarking the recipes and organising the bookmarks in your browser, but that seems quite impractical.

@m4lt3 m4lt3 added the enhancement New feature or request label Feb 18, 2021
@seyfeb
Copy link
Collaborator

seyfeb commented Feb 22, 2021

I leave here as a reference #340, though there is a lot to read. There the support of multiple cookbooks is discussed, which might be an orthogonal concept to collections.

@christianlupus
Copy link
Collaborator

I am not sure, what @m4lt3 is intending to achieve here. Let's put the implementation aside, the question is why is it needed.

I can think of two basic use cases:

  1. Organisation of recipes in separate folders. Then we are more concerned about Meta: Future file structure #340. The real intention is a cleaner file structure in the NC instance.
  2. Partitioning of the set of recipes into (virtual) subsets. Here, keywords/tags would maybe be the way to go. The intention would be merely a nicer user interface/experience during the navigation.

Especially for point 2, it might be an option to make the keywords hierarchical in a tree-like structure. Then, each user could have a custom recipe structure to organize the recipes in these. Details must be discussed of course.
This would have to be represented in the UI of course.

@Donatzsky
Copy link

@christianlupus This is clearly about case 2.

My suggestion would be to repurpose categories, instead of adding yet another organisational layer. So stick with the current categories + tags, but make it so a recipe can have more than one category. Perhaps also make categories hierarchical, but that's a separate discussion, I think.

@christianlupus
Copy link
Collaborator

The categories are not very powerful. They are only text (ref).

One could think of allowing multiple categories per recipe but hierarchical categories are unfortunately out of scope.

The thing with the separate folders is more about the sharing feature (#82).

Yet still, as we are short in manpower, every new feature needs a clean plan unless a volunteer hands in a PR. So, to avoid unneeded and potentially complex code changes that bloat the feature list, it would be very important why this feature is needed. Give an example. Get concrete. Make clear why the keywords e.g. are not sufficient.

Just by creating a new category (that you have to attach manually to each recipe), you have all recipes in one view. The keywords can do this just now already. You can (currently) not do any batch operations on the recipes. So, I do not get the point here, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

4 participants