Client side encryption v3 #87

tcanabrava · 2017-12-12T11:49:41Z

⚠️ Remove c04d1f1 before merge! ⚠️

Done:

In Progress:

Upload the encrypted file.
Encrypt the file for upload
- Simple function to do this committed

Not Started:

Download
Handle the metadata
setup the encrypted file for upload (luckly there will be no changes in the uploader itself)
finish upload, unlock folder.

Currently Completely Missing:

Download.
Should be somewhere around PropagateDownloadCommon
Lock / Unlock code can be stolen from PropagateUploadCommon
Metadata code should be mostly there.
Find out how to deal with the sync for encrypted folders as the file will be downloaded without requesting the encryption status, so only after the download is finished we can do something about that.

TODO:

Delete keys + mmonic on account deletion (@rullzer)

For some reason, this was working untill I added a call to X509_REQ_get_subject_name, then the linking suddenly stopped working (even tougth I'm using a ton of other OpenSSL calls) Force to link against 1.0

I still need to send it to the server. It's been a long learning with the OpenSSL library.

Store it on memory, and discard it as soon as no longer needed.

There's something wrong on the CSR job that I need to discover.

finally. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>

Enter a string list, return a string.

beware, this is broken.

We changed the name.

If we manage to encrypt and upload the private key to the server, the client is in it's connected state.

This new job sets the Encryption Flag in a folder.

- change the name of one Qt Message Handler - changed parameter from int to QString

This is already being called from somwhere else.

Since those networkjobs are all about client side encryption, mvoe them to clientsideencryption.h This will help with fewer conflicts with the origin.

Because nobody deservers to deal with Qt's JSON API

- TODO: Fix the incorrect "filename has been removed" popup. The file is not removed, just the popup shows.

Android only creates the metadata file when the first encrypted file is added. We assumed it would be there. This hacky code makes us store the metadata if there wasn't any yet. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

FIXES: #149

See nextcloud/end_to_end_encryption_rfc#13 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

If the code was not complex enough syncing two tables already started to give UNIQUE constrains errors on simple sync operations, this also adds initial support remote delete of an encrypted file

This has no use outside of the clientsidenecryption.cpp

…into clientSideEncryptionV3

tcanabrava added 30 commits October 18, 2017 21:51

[cse] s/scr/csr

42a3098

[cse] Link Against OpenSSL

c358980

For some reason, this was working untill I added a call to X509_REQ_get_subject_name, then the linking suddenly stopped working (even tougth I'm using a ton of other OpenSSL calls) Force to link against 1.0

[cse] Generate the CSE

d2992d9

I still need to send it to the server. It's been a long learning with the OpenSSL library.

[cse] Do not save the certificate on disk

ecb0502

Store it on memory, and discard it as soon as no longer needed.

[cse] Start the job to sign the public key.

3042318

[cse] Call the CSR job.

307dfd1

There's something wrong on the CSR job that I need to discover.

[cse] Correctly send the CSR

090336c

finally. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>

[cse] Save signed key on disk

69c7097

[cse] Add wordlist & related methods.

2111aea

[cse] new method, getUnifiedString

418401a

Enter a string list, return a string.

[cse] Enable OpenSSL for encryption

60729f1

[aes] fix out of bounds access.

fd00e18

[cse] Start the encryption algorithm for the Private Key

5395fc5

[cse] use PKCS5_PBKDF2_HMAC_SHA1 on the random-word passphrase

77c0309

[cse] Add the crypt method, based on OpenSSL Wiki

6b53b4f

[aes] Create the Decrypt function.

4f7265c

[cse] Update the encrypt and decrypt algorithm to GCM

e0d368c

[cse] Call the encrypt and decrypt functions on fake data

ba3d2a6

[cse] Use fake data to verify the encryption

0f14807

beware, this is broken.

[CSE] Adjust the calls to ent-to-end encryption

08dfe86

We changed the name.

[CSE] Debug statements to help find the encrypt error

78136a1

[CSE] Send the Private Key to the server

cfb6e3b

[CSE] Correctly Set's the client as connected

0b50afe

If we manage to encrypt and upload the private key to the server, the client is in it's connected state.

[CSE] Better debug output

1436d5b

[CSE] Helper functions for the URL's

623eb29

[CSE] SetEncryptionFlagApiJob

d83e881

This new job sets the Encryption Flag in a folder.

[CSE] Build fix

e0988f4

- change the name of one Qt Message Handler - changed parameter from int to QString

[CSE] Remove unused function

1a47052

This is already being called from somwhere else.

[CSE] Move network jobs out of networkjobs.h

23f5bb7

Since those networkjobs are all about client side encryption, mvoe them to clientsideencryption.h This will help with fewer conflicts with the origin.

[CSE] Add Nlohmann's json library

bb53c25

Because nobody deservers to deal with Qt's JSON API

tcanabrava and others added 4 commits January 28, 2018 23:59

[CSE] Ignore renames for downloaded files.

f4a50e8

- TODO: Fix the incorrect "filename has been removed" popup. The file is not removed, just the popup shows.

Merge branch 'master' into clientSideEncryptionV3

d24a1e5

[Buildfix] Fix build from last merge

dcc9ac7

rullzer added 2. developing feature: 🔒 end to end encryption labels Jan 30, 2018

rullzer and others added 14 commits January 30, 2018 11:10

Fix building on windows

d85c2bf

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Use NC windows installer images

f8d805d

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Make different program so it doesn't mess with existing config

c04d1f1

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Better explanation for encryption passphrase

080c5ea

FIXES: #149

Use standardized filename

1eb7ba7

See nextcloud/end_to_end_encryption_rfc#13 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Remove table for e2e and add an e2eMangledName column (#169)

9911707

If the code was not complex enough syncing two tables already started to give UNIQUE constrains errors on simple sync operations, this also adds initial support remote delete of an encrypted file

Move BIO2ByteArray to annonymous namespace

5faeca1

This has no use outside of the clientsidenecryption.cpp

Return the error reported by openssl

176a42a

Don't class what's not a class

7da0764

Return boolean for fileDecryption

9220fd3

Encrypt and Decrypt return bool for success

02280ff

Return bool for error

f2332c5

Create a function to handle errors

7d48703

More error handling

e3b742b

tobiasKaminsky mentioned this pull request Feb 19, 2018

How to use e2e encryption? #178

Closed

dantti and others added 6 commits February 20, 2018 21:59

Make sure folder is unlocked on upload when some errors occour

96bc8a2

Merge branch 'master' into clientSideEncryptionV3

fa99764

Merge branch 'clientSideEncryptionV3' of github.com:nextcloud/client …

99591d1

…into clientSideEncryptionV3

Many Many error handlings added.

8172f32

Handle Errors ++

db3d4be

[E2E] More debug, error handling, remove unused signals / methods.

55324d1

rullzer closed this Apr 26, 2018

rullzer deleted the clientSideEncryptionV3 branch April 26, 2018 18:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client side encryption v3 #87

Client side encryption v3 #87

tcanabrava commented Dec 12, 2017 •

edited by rullzer

Loading

Client side encryption v3 #87

Client side encryption v3 #87

Conversation

tcanabrava commented Dec 12, 2017 • edited by rullzer Loading

tcanabrava commented Dec 12, 2017 •

edited by rullzer

Loading