Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High CPU cost in app.php #96

Closed
MorrisJobke opened this issue Jan 21, 2019 · 3 comments
Closed

High CPU cost in app.php #96

MorrisJobke opened this issue Jan 21, 2019 · 3 comments
Labels
bug Something isn't working technical debt Technical issue

Comments

@MorrisJobke
Copy link
Member

The E2EE app registers an event listener for the "user deleted" hook. For this it needs the KeyStorage which is initialized in the register method. The constructor of the KeyStorage calls the method checkFolderStructure() which itself fetches the app data folder / and this operation is quite expensive - in our case it adds 170 ms to the whole request.

We should try to avoid such costly requests to each request and untangle the hooks a bit more. Hook registration should be super lightweight.

@schiessle Where is this checkFolderStructure() really needed? Can we move this somewhere else so that it is not executed on every request?

bildschirmfoto 2019-01-21 um 11 13 18

cc @nickvergessen @rullzer

@MorrisJobke MorrisJobke added bug Something isn't working technical debt Technical issue labels Jan 21, 2019
@tobiasKaminsky
Copy link
Member

Is this fixed?

@nickvergessen
Copy link
Member

#97 removed like 20% of the total load, I guess there is more we could optimize, but not sure because i didnt install this app yet

@MorrisJobke
Copy link
Member Author

Most of this is fixed in #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical debt Technical issue
Projects
None yet
Development

No branches or pull requests

3 participants