Do not set retry flag on ForbiddenException #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
rullzer
approved these changes
Sep 3, 2020
|
Well there is a request time option on access control, or your IP could change. But I tend to agree it makes no sense in most cases. |
|
It sounds to be a corner case in several directions, i.e. already uploading into restricted directories. If avoiding the chance to have stray part files is more important than to keep the state in those other conditions, then yes, sure. Will take away a bit of conformability with those edge cases. I arrive at the same conclusion as @nickvergessen. |
blizzz
approved these changes
Sep 3, 2020
|
/backport to stable19 |
|
/backport to stable18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For nextcloud/server#22556
From owncloud/core#20494 i assumed that the retry was introduced to indicate that clients should try to sync again at a later point, so I think it makes sense to not set this for files_accesscontrol thrown ForbiddenExceptions.