Do not keep the part file if the forbidden exception has no retry set #22556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… false Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
requested review from
ChristophWurst,
rullzer,
nickvergessen and
blizzz
rullzer
approved these changes
Sep 3, 2020
blizzz
approved these changes
Sep 3, 2020
|
/backport to stable19 |
|
/backport to stable18 |
This was referenced Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #22128 where the .ocTransferId[RND].part file still was kept in the users folder when an upload is being blocked by files_accesscontrol.
This requires nextcloud/files_accesscontrol#163 to work.
From owncloud/core#20494 i assumed that the retry was introduced to indicate that clients should try to sync again at a later point, so I think it makes sense to not set this for files_accesscontrol thrown ForbiddenExceptions.