Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not prevent editing files #25

Closed
jospoortvliet opened this issue Feb 21, 2020 · 2 comments
Closed

Does not prevent editing files #25

jospoortvliet opened this issue Feb 21, 2020 · 2 comments

Comments

@jospoortvliet
Copy link
Member

  1. create a markdown or office file
  2. share the file with user X
  3. lock the file
  4. log in as user X and edit the file with Text or ONLYOFFICE - no problems... Which is a problem ;-)

Updated-from-16 local test instance of Nc 18.0.1, 0.8.1 version of the app.

@ArtificialOwl
Copy link
Member

Ok, this is a known issue that is related to Text and onlyoffice and their way to sharing collaborated modification on a file throw a temporary file/buffer:

  • userA lock the file and open the file in Text App,
  • userB open the file in Text App,
  • userB can edit the file, but cannot save the modification on the filesystem, however the modification are sync on a temporary file and synchronize with the opened session from userA,
  • userA's session autosave modification from both users on the filesystem.

tl;dr: userB's edit are shared to userA that have writing access to the file.

The solution is to have those apps to check if the file is manually/temporary locked: nextcloud/server#18080

@ArtificialOwl
Copy link
Member

(i am closing the issue as this cannot be done from the files_lock app, but have to be implemented in any collaborating app)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants