Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Fixing performance issues programme #18

Closed
7 tasks done
oparoz opened this issue Sep 4, 2016 · 7 comments
Closed
7 tasks done

Fixing performance issues programme #18

oparoz opened this issue Sep 4, 2016 · 7 comments
Assignees
Labels
enhancement New feature or request performances Performances issues and optimisations

Comments

@oparoz
Copy link
Member

oparoz commented Sep 4, 2016

From @oparoz on February 28, 2015 12:19

This is a meta ticket which tracks all the various work being done to improve the performance of the app

Please support and comment on individual tickets if you want to help as it's difficult to track what's important to backers otherwise.

Loading the app

Getting thumbnails

For issues in core, see this meta ticket: owncloud/core#13609
Things should be much better on oC 8.1+, once core can generate thumbnails in seconds rather than minutes for large media files.

Feel free to add your thoughts and to raise new issues to address specific problems.

Copied from original issue: owncloud/gallery#43

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @cbxk1xg on March 12, 2015 23:16

I would be pleased to help you guys with the code. As I wrote earlier, I developed similar stuff before. And I guess it's more an user experience thing than a performance issue. But I do also have some ideas to improve the performance.

@oparoz oparoz self-assigned this Sep 4, 2016
@oparoz oparoz added bounty This issue have a bounty enhancement New feature or request performances Performances issues and optimisations priority labels Sep 4, 2016
@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

That's great news! :)
From my point of view, what's most needed is fixes in core regarding thumbnail generation:

  • Having preview categories and returning a predefined thumbnail. Asked size is 1920x1080, which is larger than 1024x1024, but smaller than 2048x2048. Return 1024 or 2048 and let the browser shrink it, etc.
  • Async thumbnail generation, triggered at upload time Migrate preview generation to async job execution owncloud/core#11685 (comment) , but we're told to wait for a solution. Also, bear in mind that in 8.1, we should have the max preview which is used to create all the smaller sizes.

In the app itself, we could have this:

But I also would like to hear what you thought of :)
Make sure you check with me before touching files as some classes may already be in a different state internally, so that we can work together.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @libasys on March 31, 2015 5:51

A new idea to fix performance issue, i have changed the gallery searching mechanism. In OC core you have a function called searchRaw. With this function you can search explicite for a file. My idea, I place or rename an image to "cover.jpg" in a folder. Now with the search function above, we only search for folders with "cover.jpg". With this mechanism you have a simple structure and a big performance improvement. The 2. part, i use the cover.jpg as thumbnail for the folder and as info, so if you add iptc information to this file like title, than the folder gets the title of the cover.jpg! So you need no startpath and no scanning for all files. You have the control what is shown up in the gallery! No need to walk from folder to subfolder and soon!

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

Could I ask you to open a separate issue for this so that people can voice their opinion?

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

occ command to generate thumbnails: owncloud/gallery#387

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

There is now a PR to show thumbnails before the row is completed: #511

@oparoz
Copy link
Member Author

oparoz commented Apr 20, 2017

Thumbnails are generated via external app

@oparoz oparoz closed this as completed Apr 20, 2017
@oparoz oparoz removed the bounty This issue have a bounty label Apr 20, 2017
@oparoz oparoz changed the title Fixing performance issues programme [$60] Fixing performance issues programme Apr 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request performances Performances issues and optimisations
Projects
None yet
Development

No branches or pull requests

1 participant