Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving a versioned file into a groupfolder results in having versions on local system for the groupfolder path #2343

Open
AndyXheli opened this issue Apr 20, 2023 · 3 comments
Labels
0. Needs triage Issues that need to be triaged bug feature: versions Items related to file versioning

Comments

@AndyXheli
Copy link

AndyXheli commented Apr 20, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Upgrade to NC 26.0.1 from NC 25.0.6
  2. See [Bug]: NC 25 Error: Undefined array key "extension" at /var/www/nextcloud/apps/files_versions/lib/Storage.php#489 server#34085 (comment)

So, this bug seems specific to groupfolders in the end, which have their own backend for both trash and versions.

From what I understand, the bug is related to:

A file is created outside groupfolders

  1. The file is modified and versions are stored
  2. The file is moved into a groupfolder (most likely a whole folder is moved into a groupfolder, containing versioned files)
  3. The file is deleted from groupfolder (most likely its parent folder)
  4. Somehow this results in the event trying to delete versions on a folder rather than a file

What I could reproduce already is that moving a versioned file into a groupfolder results in having versions with local system for the groupfolder path, which does not happen for files created directly in the groupfolder.

Actual behaviour

This might be similar too nextcloud/server#34085 & it was fixed in nextcloud/server#34528

Server configuration

Operating system:
Ubuntu 22.0.4

Web server:
Apache2

Database:
MariaDB

PHP version:
8.1

Nextcloud version: (see Nextcloud admin page)
26.0.1

Group folders version:
14.0.1

Updated from an older Nextcloud/ownCloud or fresh install:
NC 25.0.6

Where did you install Nextcloud from:

Are you using external storage, if yes which one: local/s3/smb/sftp/...
No

Are you using encryption: yes/no
No

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/Saml/...
LDAP

Logs

Nextcloud log (data/nextcloud.log)

Nextcloud log
{"reqId":"MrIJw0AChp1Cvu2tK0h5","level":3,"time":"2023-04-20T14:19:57+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Undefined array key 176125 at /var/www/nextcloud/apps/files_versions/lib/Storage.php#615","userAgent":"--","version":"26.0.1.1","data":{"app":"PHP"},"id":"644159c140205"}
@AndyXheli AndyXheli added 0. Needs triage Issues that need to be triaged bug labels Apr 20, 2023
@solracsf solracsf changed the title Undefined array key 176125 at /var/www/nextcloud/apps/files_versions/lib/Storage.php#615 Undefined array key 176125 at /apps/files_versions/lib/Storage.php#615 Apr 30, 2023
@solracsf solracsf changed the title Undefined array key 176125 at /apps/files_versions/lib/Storage.php#615 Moving a versioned file into a groupfolder results in having versions on local system for the groupfolder path May 10, 2023
@nextcloud nextcloud deleted a comment from AndyXheli May 10, 2023
@AndyXheli
Copy link
Author

AndyXheli commented May 12, 2023

Quick question would this also be solved via nextcloud/server#38224 ?

@solracsf
Copy link
Member

It won't be solved, because the problem of moving files (versions) between backends remains, but you won't get the error.

@joshtrichards
Copy link
Member

I believe this should have gotten better after #2910.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged bug feature: versions Items related to file versioning
Projects
None yet
Development

No branches or pull requests

3 participants