[Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given #37407

BJKle · 2023-03-26T08:36:38Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
Nextcloud Server is running on 64bit capable CPU, PHP and OS.
I agree to follow Nextcloud's Code of Conduct.

Bug description

In my error log I can find the following errors every 12 hours since updating to NC 26 and PHP 8.2:

Undefined array key 169178 at /var/www/nextcloud/apps/files_versions/lib/Storage.php#615

TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given, called in /var/www/nextcloud/apps/files_versions/lib/Storage.php on line 615

Steps to reproduce

don't know

Expected behavior

no error

Installation method

Community Manual installation with Archive

Operating system

Debian/Ubuntu

PHP engine version

Other

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

No response

List of activated Apps

Enabled:
  - activity: 2.18.0
  - admin_audit: 1.16.0
  - cloud_federation_api: 1.9.0
  - dav: 1.25.0
  - federatedfilesharing: 1.16.0
  - files: 1.21.1
  - files_pdfviewer: 2.7.0
  - files_rightclick: 1.5.0
  - files_sharing: 1.18.0
  - files_trashbin: 1.16.0
  - files_versions: 1.19.1
  - geoblocker: 0.5.7
  - groupfolders: 14.0.0
  - logreader: 2.11.0
  - lookup_server_connector: 1.14.0
  - notes: 4.7.2
  - notifications: 2.14.0
  - oauth2: 1.14.0
  - password_policy: 1.16.0
  - photos: 2.2.0
  - previewgenerator: 5.2.1
  - privacy: 1.10.0
  - provisioning_api: 1.16.0
  - recommendations: 1.5.0
  - related_resources: 1.1.0-alpha1
  - serverinfo: 1.16.0
  - settings: 1.8.0
  - sharebymail: 1.16.0
  - systemtags: 1.16.0
  - text: 3.7.2
  - theming: 2.1.1
  - twofactor_backupcodes: 1.15.0
  - updatenotification: 1.16.0
  - viewer: 1.10.0
  - workflowengine: 2.8.0

Nextcloud Signing status

No response

Nextcloud Logs

[cron] Error: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given, called in /var/www/nextcloud/apps/files_versions/lib/Storage.php on line 615 at <<closure>>

0. /var/www/nextcloud/apps/files_versions/lib/Storage.php line 615
   OCP\AppFramework\Db\QBMapper->delete()
1. /var/www/nextcloud/apps/files_versions/lib/BackgroundJob/ExpireVersions.php line 69
   OCA\Files_Versions\Storage::expireOlderThanMaxForUser()
2. /var/www/nextcloud/lib/private/User/Manager.php line 639
   OCA\Files_Versions\BackgroundJob\ExpireVersions->OCA\Files_Versions\BackgroundJob\{closure}("*** sensitive parameters replaced ***")
3. /var/www/nextcloud/apps/files_versions/lib/BackgroundJob/ExpireVersions.php line 64
   OC\User\Manager->callForSeenUsers()
4. /var/www/nextcloud/lib/public/BackgroundJob/Job.php line 78
   OCA\Files_Versions\BackgroundJob\ExpireVersions->run()
5. /var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php line 103
   OCP\BackgroundJob\Job->start()
6. /var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php line 93
   OCP\BackgroundJob\TimedJob->start()
7. /var/www/nextcloud/cron.php line 152
   OCP\BackgroundJob\TimedJob->execute()

at 2023-03-25T18:40:02+01:00

Additional info

No response

The text was updated successfully, but these errors were encountered:

szaimen · 2023-03-26T08:37:59Z

Cc @artonge

BJKle · 2023-03-26T21:10:07Z

The following new code line 615 is the cause:
$versionsMapper->delete($versionEntities[$version->getId()]);
Merged on Jan 26, 2023

Kalle73kw · 2023-04-09T08:58:17Z

Is there a workaround or fix already?

erwdavid · 2023-04-14T10:38:23Z

same thing with NC 26 on FreeBSD, php 8.2
It appears in cron jobs

Kalle73kw · 2023-04-14T11:00:51Z

Deleting all versions (php occ versions:cleanup) and deactivating the versions app stopped the errors at least for now. 💁🏻‍♂️

AndyXheli · 2023-04-20T14:19:29Z

Same issue running NC 26.0.1 on Ubuntu, PHP 8.1, MySQL 10.3.38

{"reqId":"c4QecNyf5eGERWPEwLr6","level":3,"time":"2023-04-20T14:10:25+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"OCP\\AppFramework\\Db\\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\\AppFramework\\Db\\Entity, null given, called in /var/www/nextcloud/apps/files_versions/lib/Storage.php on line 615","userAgent":"--","version":"26.0.1.1","exception":{"Exception":"TypeError","Message":"OCP\\AppFramework\\Db\\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\\AppFramework\\Db\\Entity, null given, called in /var/www/nextcloud/apps/files_versions/lib/Storage.php on line 615","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/files_versions/lib/Storage.php","line":615,"function":"delete","class":"OCP\\AppFramework\\Db\\QBMapper","type":"->"},{"file":"/var/www/nextcloud/apps/files_versions/lib/BackgroundJob/ExpireVersions.php","line":69,"function":"expireOlderThanMaxForUser","class":"OCA\\Files_Versions\\Storage","type":"::"},{"file":"/var/www/nextcloud/lib/private/User/Manager.php","line":639,"function":"OCA\\Files_Versions\\BackgroundJob\\{closure}","class":"OCA\\Files_Versions\\BackgroundJob\\ExpireVersions","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/apps/files_versions/lib/BackgroundJob/ExpireVersions.php","line":70,"function":"callForSeenUsers","class":"OC\\User\\Manager","type":"->"},{"file":"/var/www/nextcloud/lib/public/BackgroundJob/Job.php","line":78,"function":"run","class":"OCA\\Files_Versions\\BackgroundJob\\ExpireVersions","type":"->"},{"file":"/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php","line":103,"function":"start","class":"OCP\\BackgroundJob\\Job","type":"->"},{"file":"/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php","line":93,"function":"start","class":"OCP\\BackgroundJob\\TimedJob","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":152,"function":"execute","class":"OCP\\BackgroundJob\\TimedJob","type":"->"}],"File":"/var/www/nextcloud/lib/public/AppFramework/Db/QBMapper.php","Line":96,"CustomMessage":"--"},"id":"644149ddb5bfc"}

Error when running it via occ versions:expire

 sudo -u www-data php /var/www/nextcloud/occ versions:expire
    3 [->--------------------------]An unhandled exception has been thrown:
TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given, called in /var/www/nextcloud/apps/files_versions/lib/Storage.php on line 615 and defined in /var/www/nextcloud/lib/public/AppFramework/Db/QBMapper.php:96
Stack trace:
#0 /var/www/nextcloud/apps/files_versions/lib/Storage.php(615): OCP\AppFramework\Db\QBMapper->delete()
#1 /var/www/nextcloud/apps/files_versions/lib/Command/ExpireVersions.php(110): OCA\Files_Versions\Storage::expireOlderThanMaxForUser()
#2 /var/www/nextcloud/apps/files_versions/lib/Command/ExpireVersions.php(97): OCA\Files_Versions\Command\ExpireVersions->expireVersionsForUser()
#3 /var/www/nextcloud/lib/private/User/Manager.php(639): OCA\Files_Versions\Command\ExpireVersions->OCA\Files_Versions\Command\{closure}()
#4 /var/www/nextcloud/apps/files_versions/lib/Command/ExpireVersions.php(98): OC\User\Manager->callForSeenUsers()
#5 /var/www/nextcloud/3rdparty/symfony/console/Command/Command.php(255): OCA\Files_Versions\Command\ExpireVersions->execute()
#6 /var/www/nextcloud/3rdparty/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run()
#7 /var/www/nextcloud/3rdparty/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#8 /var/www/nextcloud/3rdparty/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun()
#9 /var/www/nextcloud/lib/private/Console/Application.php(215): Symfony\Component\Console\Application->run()
#10 /var/www/nextcloud/console.php(100): OC\Console\Application->run()
#11 /var/www/nextcloud/occ(11): require_once('...')

vanoc · 2023-04-24T15:46:08Z

same error.
Centos 8, PHP 8.1.18, Nextcloud 26.0.1

erwdavid · 2023-04-24T15:55:26Z

Le 24/04/2023 à 17:46, vanoc a écrit :

same error. Centos 8, PHP 8.1.18 — Reply to this email directly, view it on GitHub <#37407 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACM6LRZEDCMWASMSB2RNCBTXC2N4XANCNFSM6AAAAAAWIBNJSU>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Error is still here in Nextcloud 26.0.1

WolkeOsch · 2023-04-28T08:14:44Z

Made upgrade to v26 (php 8.1.2 - ubuntu 22 ) yesterday. Got the same error message within 12 hours.

BJKle · 2023-04-30T06:59:31Z

@artonge Any development? Could you please post a status and an timeline? Thank you.

solracsf · 2023-05-08T12:27:00Z

Fix released at #38125

BJKle · 2023-05-09T21:41:22Z

@solracsf
Thank you.
replaced the old version with your fix.
The "TypeError" is gone but the 1st error:
Undefined array key 171289 at /var/www/nextcloud/apps/files_versions/lib/Storage.php#616
is still present
now when calling the newly introduced code:

            $versionEntity = $versionEntities[$version->getId()];

instead of 2 every 12 hours I get 16 now.

solracsf · 2023-05-10T06:57:06Z

The undefined array key is a duplicate of nextcloud/groupfolders#2343

solracsf · 2023-05-10T07:14:54Z

@BJKle @AndyXheli can you replace :

$versionEntity = $versionEntities[$version->getId()];

with

$versionEntity = isset($versionEntities[$version->getId()]) ? $versionEntities[$version->getId()] : null;

And see if helps?

BJKle · 2023-05-11T17:34:32Z

Thanks. But I’ll just wait for the official version.

solracsf · 2023-05-11T19:56:50Z

Did you know that an official version will come out only if someone (like me) reproduces the bug and helps fix it?
But i understand, you don't want to lose your time, I won't lose mine either 😉

AndyXheli · 2023-05-11T19:58:21Z

@solracsf I can give it a test what file would you like me to change ?

solracsf · 2023-05-11T20:01:24Z

After aplying #38125
Edit that portion again and do #37407 (comment)

solracsf · 2023-05-11T20:02:24Z

Final code is:

foreach ($versions as $version) {
	$internalPath = $version->getInternalPath();
	\OC_Hook::emit('\OCP\Versions', 'preDelete', ['path' => $internalPath, 'trigger' => self::DELETE_TRIGGER_RETENTION_CONSTRAINT]);

	$versionEntity = isset($versionEntities[$version->getId()]) ? $versionEntities[$version->getId()] : null;
	if (!is_null($versionEntity)) {
		$versionsMapper->delete($versionEntity);
	}

	$version->delete();
	\OC_Hook::emit('\OCP\Versions', 'delete', ['path' => $internalPath, 'trigger' => self::DELETE_TRIGGER_RETENTION_CONSTRAINT]);
}

AndyXheli · 2023-05-11T20:09:48Z

Thank you! I'll give it a try and keep you posted.

AndyXheli · 2023-05-12T13:29:49Z

@solracsf Looks good on my server. Before the change

After apply the patches ran an occ with no issues

Also i did see the

Undefined array key 943358 at /var/www/nextcloud/apps/files_versions/lib/Storage.php#615

in error logs. After applying it seems to be gone.

erwdavid · 2023-05-12T13:37:18Z

I applied it, after a few days : it works!

solracsf · 2023-05-12T14:06:13Z

Thanks for your feedback. Patch at #38224

BJKle added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Mar 26, 2023

szaimen added the 26-feedback label Mar 26, 2023

szaimen mentioned this issue Mar 26, 2023

Update to nc26 nextcloud/all-in-one#1846

Closed

37 tasks

solracsf changed the title ~~[Bug]: /var/www/nextcloud/apps/files_versions/lib/Storage.php#615~~ [Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given Mar 26, 2023

artonge self-assigned this Mar 29, 2023

szaimen mentioned this issue Apr 14, 2023

tasks for nc26 nextcloud/all-in-one#2336

Closed

45 tasks

solracsf mentioned this issue May 8, 2023

Check if version entity is not null before delete #38125

Merged

4 tasks

skjnldsv closed this as completed in #38125 May 9, 2023

solracsf mentioned this issue May 12, 2023

Check if version has entity before trying to access it #38224

Merged

4 tasks

This comment was marked as off-topic.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given #37407

[Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given #37407

BJKle commented Mar 26, 2023 •

edited by solracsf

Loading

szaimen commented Mar 26, 2023

BJKle commented Mar 26, 2023

Kalle73kw commented Apr 9, 2023

erwdavid commented Apr 14, 2023

Kalle73kw commented Apr 14, 2023

AndyXheli commented Apr 20, 2023 •

edited

Loading

vanoc commented Apr 24, 2023 •

edited

Loading

erwdavid commented Apr 24, 2023 via email

WolkeOsch commented Apr 28, 2023

BJKle commented Apr 30, 2023

solracsf commented May 8, 2023 •

edited

Loading

BJKle commented May 9, 2023 •

edited

Loading

solracsf commented May 10, 2023

solracsf commented May 10, 2023 •

edited

Loading

BJKle commented May 11, 2023

solracsf commented May 11, 2023 •

edited

Loading

AndyXheli commented May 11, 2023

solracsf commented May 11, 2023

solracsf commented May 11, 2023 •

edited

Loading

AndyXheli commented May 11, 2023

AndyXheli commented May 12, 2023 •

edited by solracsf

Loading

erwdavid commented May 12, 2023 via email •

edited by solracsf

Loading

solracsf commented May 12, 2023

This comment was marked as off-topic.

[Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given #37407

[Bug]: TypeError: OCP\AppFramework\Db\QBMapper::delete(): Argument #1 ($entity) must be of type OCP\AppFramework\Db\Entity, null given #37407

Comments

BJKle commented Mar 26, 2023 • edited by solracsf Loading

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Installation method

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

szaimen commented Mar 26, 2023

BJKle commented Mar 26, 2023

Kalle73kw commented Apr 9, 2023

erwdavid commented Apr 14, 2023

Kalle73kw commented Apr 14, 2023

AndyXheli commented Apr 20, 2023 • edited Loading

vanoc commented Apr 24, 2023 • edited Loading

erwdavid commented Apr 24, 2023 via email

WolkeOsch commented Apr 28, 2023

BJKle commented Apr 30, 2023

solracsf commented May 8, 2023 • edited Loading

BJKle commented May 9, 2023 • edited Loading

solracsf commented May 10, 2023

solracsf commented May 10, 2023 • edited Loading

BJKle commented May 11, 2023

solracsf commented May 11, 2023 • edited Loading

AndyXheli commented May 11, 2023

solracsf commented May 11, 2023

solracsf commented May 11, 2023 • edited Loading

AndyXheli commented May 11, 2023

AndyXheli commented May 12, 2023 • edited by solracsf Loading

erwdavid commented May 12, 2023 via email • edited by solracsf Loading

solracsf commented May 12, 2023

This comment was marked as off-topic.

BJKle commented Mar 26, 2023 •

edited by solracsf

Loading

AndyXheli commented Apr 20, 2023 •

edited

Loading

vanoc commented Apr 24, 2023 •

edited

Loading

solracsf commented May 8, 2023 •

edited

Loading

BJKle commented May 9, 2023 •

edited

Loading

solracsf commented May 10, 2023 •

edited

Loading

solracsf commented May 11, 2023 •

edited

Loading

solracsf commented May 11, 2023 •

edited

Loading

AndyXheli commented May 12, 2023 •

edited by solracsf

Loading

erwdavid commented May 12, 2023 via email •

edited by solracsf

Loading