allow empty response from OpenProject

Signed-off-by: Artur Neumann <artur@jankaritech.com>
nextcloud · Mar 15, 2022 · a7b8611 · a7b8611
1 parent fcc17e3
commit a7b8611
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/src/views/ProjectsTab.vue b/src/views/ProjectsTab.vue
@@ -99,12 +99,15 @@ export default {
 			const url = generateUrl('/apps/integration_openproject/work-packages?fileId=' + fileId)
 			try {
 				const response = await axios.get(url, req)
-				if (!Array.isArray(response.data) || response.data.length < 1) {
+				if (!Array.isArray(response.data)) {
 					this.state = 'failed-fetching-workpackages'
 				} else {
-					for (let workPackage of response.data) {
-						workPackage = await workpackageHelper.getAdditionalMetaData(workPackage)
-						this.workpackages.push(workPackage)
+					// empty data means there are no workpackages linked
+					if (response.data.length > 0) {
+						for (let workPackage of response.data) {
+							workPackage = await workpackageHelper.getAdditionalMetaData(workPackage)
+							this.workpackages.push(workPackage)
+						}
 					}
 					this.state = 'ok'
 				}

diff --git a/tests/jest/views/ProjectsTab.spec.js b/tests/jest/views/ProjectsTab.spec.js
@@ -72,7 +72,6 @@ describe('ProjectsTab.vue Test', () => {
 			expect(wrapper.vm.state).toBe(cases.AppState)
 		})
 		it.each([
-			[],
 			null,
 			'string',
 			undefined,
@@ -168,7 +167,7 @@ describe('ProjectsTab.vue Test', () => {
 					project: { },
 				},
 			}],
-		])('sets "failed-fetching-workpackages" state on invalid responses', async (testCase) => {
+		])('sets the "failed-fetching-workpackages" state on invalid responses', async (testCase) => {
 			axios.get
 				.mockImplementationOnce(() => Promise.resolve({
 					status: 200,
@@ -179,6 +178,12 @@ describe('ProjectsTab.vue Test', () => {
 			await wrapper.vm.update({ id: 123 })
 			expect(wrapper.vm.state).toBe('failed-fetching-workpackages')
 		})
+		it('sets the "ok" state on empty response', async () => {
+			axios.get
+				.mockImplementation(() => Promise.resolve({ status: 200, data: [] }))
+			await wrapper.vm.update({ id: 123 })
+			expect(wrapper.vm.state).toBe('ok')
+		})
 		it.each([
 			{ statusColor: { color: '#A5D8FF' }, typeColor: { color: '#00B0F0' } },
 			{ statusColor: { }, typeColor: { } },