document release process #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Neumann <artur@jankaritech.com>
README.md
Outdated
| @@ -160,3 +160,9 @@ Now you can watch for the app code changes using the following command and start | |||
| cd $HOME/development/custom_apps/integration_openproject | |||
| npm run watch | |||
| ``` | |||
|
|
|||
| ### Release: | |||
| - tag a commit on master. The tag has to have the format `v1.1.1` for releases and `v1.1.1-20220728-nightly` for nightly builds | |||
There was a problem hiding this comment.
Suggested change
| - tag a commit on master. The tag has to have the format `v1.1.1` for releases and `v1.1.1-20220728-nightly` for nightly builds | |
| - Tag a commit on `master` branch. The tag has to have the format `v1.1.1` for releases and `v1.1.1-20220728-nightly` for nightly builds |
README.md
Outdated
| ### Release: | ||
| - tag a commit on master. The tag has to have the format `v1.1.1` for releases and `v1.1.1-20220728-nightly` for nightly builds | ||
| e.g: `git tag v1.0.6-20220728-nightly -m"v1.0.6-20220728-nightly"` | ||
| - push the tag to the release branch: `git push origin master:release --tags -f` |
There was a problem hiding this comment.
Suggested change
| - push the tag to the release branch: `git push origin master:release --tags -f` | |
| - Push the tag to the release branch: `git push origin master:release --tags -f` |
do we have to do a force push -f here?
README.md
Outdated
| - tag a commit on master. The tag has to have the format `v1.1.1` for releases and `v1.1.1-20220728-nightly` for nightly builds | ||
| e.g: `git tag v1.0.6-20220728-nightly -m"v1.0.6-20220728-nightly"` | ||
| - push the tag to the release branch: `git push origin master:release --tags -f` | ||
| - approve deployment in GitHub actions |
There was a problem hiding this comment.
Suggested change
| - approve deployment in GitHub actions | |
| - Approve the deployment in GitHub actions |
| @@ -160,3 +160,9 @@ Now you can watch for the app code changes using the following command and start | |||
| cd $HOME/development/custom_apps/integration_openproject | |||
| npm run watch | |||
| ``` | |||
|
|
|||
| ### Release: | |||
There was a problem hiding this comment.
the ordered list may be better for this, as it is a step-wise process.
Signed-off-by: Artur Neumann <artur@jankaritech.com>
JS Code CoverageCoverage after merging documentRelease into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kiranparajuli589
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document how to release the app
fixes https://community.openproject.org/projects/nextcloud-integration/work_packages/42808