Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#43529] document serving NC from subfolder via docker #196

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

individual-it
Copy link
Collaborator

document a "simple" way to serve NC from a subfolder (/html) with the existing docker containers

Signed-off-by: Artur Neumann <artur@jankaritech.com>
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 few minor English nitpicks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: PKiran <39373750+kiranparajuli589@users.noreply.github.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

JS Code Coverage

Coverage after merging subfolder into master will be
86.16%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   bootstrap.js0%0%0%0%1, 1–7
   dashboard.js0%0%0%0%1, 1, 10–19, 2, 20–27, 3–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
   utils.js57.45%33.33%50%59.52%10–14, 17–26, 6–9
src/components
   AdminSettings.vue99.35%95.56%86.67%100%1, 1
   OAuthConnectButton.vue99.08%80%100%100%1
   PersonalSettings.vue98.09%71.43%50%99.50%1, 1, 1
src/components/admin
   FieldValue.vue95.56%62.50%100%98.77%1, 1, 1, 1
   FormHeading.vue98.98%75%100%100%1
   TextInput.vue98.35%75%85.71%100%1, 1, 1
src/components/icons
   ClippyIcon.vue93.18%50%50%97.50%1, 1
src/components/settings
   SettingsTitle.vue95.56%50%100%97.62%1, 1
src/components/tab
   EmptyContent.vue99.34%90.91%100%100%1
   SearchInput.vue99.59%83.33%100%100%1
   WorkPackage.vue99.01%33.33%100%99.66%1, 1, 1
src/utils
   workpackageHelper.js97.46%96%100%97.75%17–19
src/views
   Dashboard.vue0%0%0%0%1, 1, 10, 100–109, 11, 110–119, 12, 120–129, 13, 130–139, 14, 140–149, 15, 150–159, 16, 160–169, 17, 170–179, 18, 180–189, 19, 190–199, 2, 20, 200–209, 21, 210–219, 22, 220–225, 23–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
   ProjectsTab.vue99.74%92.31%100%100%23

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

PHP Code Coverage

Coverage after merging subfolder into master will be
62.27%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php24%100%25%23.81%59–60, 63, 70, 74–77, 79–84, 95, 99
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php78.99%100%66.67%79.84%112–113, 115, 117–119, 121, 127–128, 130, 300–303, 305–306, 309, 317–321, 343–345, 94
   DirectDownloadController.php0%100%0%0%36–38, 53–55, 57, 60–61
   FilesController.php68.83%100%100%66.67%180–181, 226, 232–236, 240–241, 244, 246, 257–259, 262–263, 265–266, 270–273, 276
   OpenProjectAPIController.php86.86%100%84.62%87.10%124, 159, 176–177, 181, 185, 187–192, 194, 213, 238, 83
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 103–105, 112, 119–120, 122, 124–125, 127–128, 130, 133–134, 136–137, 139, 69–73, 80, 87, 94
lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
lib/Listener
   LoadSidebarScript.php0%100%0%0%100–101, 103–104, 65–70, 72–73, 75–76, 78–79, 85–86, 88, 90, 92–94, 96, 98
lib/Notification
   Notifier.php0%100%0%0%100–104, 109–110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92, 95, 97
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123–125, 127–128, 130–132, 135–136, 138–139, 143–144, 146–148, 154–155, 157, 166, 174–180, 189–194, 203, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   DirectDownloadService.php88%100%100%86.96%65–66, 68
   OauthService.php0%100%0%0%101–105, 115–118, 42–44, 53–59, 61, 70–73, 84–91
   OpenProjectAPIService.php88.07%100%92%87.69%173–177, 206–210, 364–365, 367, 379, 387, 391, 412, 490–491, 498, 501–504, 506, 512, 516–518, 690, 736, 767
lib/Settings
   Admin.php0%100%0%0%32–34, 41–43, 46–50, 53, 60, 62–63, 65, 69, 73
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php86.67%100%50%92.31%83, 87
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@individual-it individual-it merged commit 9b4ffd2 into master Aug 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the subfolder branch August 18, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants