Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP#41102] link workpackage backend #68

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

individual-it
Copy link
Collaborator

@individual-it individual-it commented Mar 10, 2022

ability to link files to packages, backend for #64
manually tested with https://github.com/opf/openproject/tree/feature/file-links

Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
@@ -83,10 +85,10 @@ describe('SearchInput.vue tests', () => {
const inputField = wrapper.find(inputSelector)
await inputField.setValue(search)
expect(axiosSpy).toHaveBeenCalledTimes(expectedCallCount)
axiosSpy.mockRestore()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restoreAllMocks in afterEach seems not to be enough
Without this some tests would pass when running all tests of the file but fail if ran single

@individual-it individual-it changed the title link workpackage backend [OP#41102] link workpackage backend Mar 11, 2022
@individual-it individual-it marked this pull request as ready for review March 11, 2022 09:48
@individual-it
Copy link
Collaborator Author

CC @Kharonus @wielinde I cannot add you as reviewers

Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
@github-actions
Copy link

JS Code Coverage

Coverage after merging addLinkToWorkpackageBackend into master will be
46.79%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   utils.js8.33%0%0%14.29%3–9, 9
src/components
   AdminSettings.vue40.91%100%16.67%50%74–76, 80, 87–88, 90, 93
   OAuthConnectButton.vue92.59%100%83.33%95.24%34
   PersonalSettings.vue33.33%26.32%27.27%38.89%102–103, 103, 103, 106–107, 107, 107, 110–111, 111, 111, 114, 117–118, 120–121, 121–123, 123, 123, 123–124, 129–130, 130, 130, 135, 141, 89–92, 98–99
src/components/settings
   SettingsTitle.vue0%100%0%0%14
src/components/tab
   EmptyContent.vue100%100%100%100%
   SearchInput.vue63.37%43.75%66.67%67.14%101, 101, 101, 144, 152–156, 161–165, 165, 165, 165–166, 181, 183–184, 186, 188–189, 189, 189, 66, 93, 93, 93–94, 96
   WorkPackage.vue100%100%100%100%
src/views
   Dashboard.vue0%0%0%0%101, 106, 106, 106–107, 109, 115, 119–120, 128, 131, 135–137, 139, 142–143, 146–147, 147–148, 152–153, 153–154, 156, 158–159, 159, 159, 159, 159–161, 161, 161, 161, 161–163, 166, 171, 171, 171, 173–174, 174, 174–175, 177, 177–179, 183, 187, 190, 190, 190, 193, 193, 193, 198, 201, 201, 201, 208, 211, 211, 211, 216, 216, 216, 22, 221, 221, 221, 226, 229, 23, 232, 235, 235, 235, 238, 238, 238, 24, 241, 244, 247, 25–30, 47, 54, 54, 61, 64–65, 77–78, 78, 78, 81, 84, 84, 84–86, 86, 86–88, 88–89, 91, 94, 94, 94–96, 96, 96–98, 98–99
   ProjectsTab.vue82.22%80%85.71%82.14%100, 100, 100–101, 103, 89–90

@github-actions
Copy link

PHP Code Coverage

Coverage after merging addLinkToWorkpackageBackend into master will be
46.10%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php0%100%0%0%49, 51–52, 54–55, 59–60, 63, 70, 74–77, 79–84, 95, 99
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php63.64%100%60%63.86%101–102, 104, 115–116, 118, 216–221, 223–226, 228, 230, 81–82, 84, 86–88, 90–95
   OpenProjectAPIController.php74.39%100%75%74.32%170, 187–188, 191, 194–199, 204, 206–211, 213, 90
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%106–109, 61–64, 71, 78, 85, 92, 99
lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectResponseException.php0%100%0%0%16
lib/Listener
   LoadSidebarScript.php0%100%0%0%59–61, 65–66, 68, 70, 72–74, 76–78
lib/Notification
   Notifier.php0%100%0%0%100–104, 109–110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92, 95, 97
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123–125, 127–131, 133–135, 138–139, 141–142, 146–147, 149–151, 157–158, 160, 169, 177–183, 192–197, 206, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   OpenProjectAPIService.php68.33%100%70.59%68.14%106–107, 116–125, 127–130, 133–138, 140–141, 144–145, 161–165, 175–176, 178–182, 184, 193–197, 392–393, 395, 410–413, 415, 483–484, 491, 494–497, 499, 505, 509–511, 682
lib/Settings
   Admin.php0%100%0%0%25–26, 33–35, 37, 42–43, 47, 51
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php0%100%0%0%38–41, 48–52, 55, 57, 59–61, 65–66, 70, 74
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@individual-it individual-it merged commit 603c605 into master Mar 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the addLinkToWorkpackageBackend branch March 14, 2022 08:27
@individual-it individual-it restored the addLinkToWorkpackageBackend branch March 14, 2022 08:27
@individual-it individual-it deleted the addLinkToWorkpackageBackend branch March 14, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants