Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP#41289] list all linked workpackages #71

Conversation

individual-it
Copy link
Collaborator

@individual-it individual-it commented Mar 14, 2022

fetches and shows all existing links between file and work-package

tested with opf/openproject#10052

fixes https://community.openproject.org/projects/nextcloud-integration/work_packages/41289

list-existing-links.mp4

@individual-it individual-it changed the title [#41289] list all linked workpackages [OP#41289] list all linked workpackages Mar 14, 2022
@individual-it individual-it force-pushed the task/41289-list-all-workpackages-that-are-linked-to-the-displayed-file branch from 1573608 to 0d7ac3c Compare March 14, 2022 08:29
@individual-it individual-it marked this pull request as ready for review March 15, 2022 11:09
@individual-it individual-it self-assigned this Mar 15, 2022
@individual-it individual-it force-pushed the task/41289-list-all-workpackages-that-are-linked-to-the-displayed-file branch from 8dc9c90 to a3c12e8 Compare March 16, 2022 08:19
Copy link
Collaborator

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than already mentioned

Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
@individual-it individual-it force-pushed the task/41289-list-all-workpackages-that-are-linked-to-the-displayed-file branch from e2d20bc to 66c24cc Compare March 17, 2022 10:42
@github-actions
Copy link

JS Code Coverage

Coverage after merging task/41289-list-all-workpackages-that-are-linked-to-the-displayed-file into master will be
54.73%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   utils.js8.33%0%0%14.29%3–9, 9
src/components
   AdminSettings.vue40.91%100%16.67%50%73–75, 79, 86–87, 89, 92
   OAuthConnectButton.vue93.10%100%85.71%95.45%49
   PersonalSettings.vue35.29%30%27.27%40.54%100–101, 104–105, 105, 105, 108–109, 109, 109, 112–113, 113, 113, 116, 119–120, 122–123, 123–125, 125, 125, 125–126, 131–132, 132, 132, 137, 143, 91–94
src/components/settings
   SettingsTitle.vue0%100%0%0%14
src/components/tab
   EmptyContent.vue100%100%100%100%
   SearchInput.vue80%58.33%76.92%85%139, 149–151, 151, 151, 151–152, 67, 94, 94, 94–95, 97
   WorkPackage.vue100%100%100%100%
src/utils
   workpackageHelper.js95.12%95.24%100%94.12%11, 19
src/views
   Dashboard.vue0%0%0%0%100–101, 101–102, 104, 107, 112, 112, 112–113, 115, 121, 125–126, 134, 137, 141–143, 145, 148–149, 152–153, 153–154, 158–159, 159–160, 162, 164–165, 165, 165, 165, 165–167, 167, 167, 167, 167–169, 172, 177, 177, 177, 179–180, 180, 180–181, 183, 183–185, 189, 193, 196, 196, 196, 199, 199, 199, 204, 207, 207, 207, 214, 217, 217, 217, 222, 222, 222, 227, 227, 227, 232, 235, 238, 24, 241, 241, 241, 244, 244, 244, 247, 25, 250, 253, 26–32, 49, 57, 57, 64, 67–68, 80–81, 81, 81, 84, 87, 87, 87–89, 89, 89–91, 91–92, 94, 97, 97, 97–99, 99, 99
   ProjectsTab.vue94.55%100%83.33%94.12%91–92

@github-actions
Copy link

PHP Code Coverage

Coverage after merging task/41289-list-all-workpackages-that-are-linked-to-the-displayed-file into master will be
46.28%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php0%100%0%0%49, 51–52, 54–55, 59–60, 63, 70, 74–77, 79–84, 95, 99
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php63.64%100%60%63.86%101–102, 104, 115–116, 118, 216–221, 223–226, 228, 230, 81–82, 84, 86–88, 90–95
   OpenProjectAPIController.php74.39%100%75%74.32%170, 187–188, 191, 194–199, 204, 206–211, 213, 90
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%106–107, 109–110, 112–113, 61–64, 71, 78, 85, 92, 99
lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectResponseException.php0%100%0%0%16
lib/Listener
   LoadSidebarScript.php0%100%0%0%59–61, 65–66, 68, 70, 72–74, 76, 78–79, 81–82
lib/Notification
   Notifier.php0%100%0%0%100–104, 109–110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92, 95, 97
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123–125, 127–131, 133–135, 138–139, 141–142, 146–147, 149–151, 157–158, 160, 169, 177–183, 192–197, 206, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   OpenProjectAPIService.php69.43%100%72.22%69.19%106–107, 116–125, 127–130, 133–138, 140–141, 144–145, 161–165, 175–176, 178–182, 184, 193–197, 392–393, 395, 410–413, 415, 483–484, 491, 494–497, 499, 505, 509–511, 682
lib/Settings
   Admin.php0%100%0%0%25–26, 33–35, 37, 42–43, 47, 51
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php0%100%0%0%38–41, 48–52, 54, 57, 59, 61–63, 67–69, 73, 77
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@individual-it individual-it merged commit 7c85e8f into master Mar 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the task/41289-list-all-workpackages-that-are-linked-to-the-displayed-file branch March 17, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants