Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag messages as spam/ham (not spam) [$15] #23

Closed
Quix0r opened this issue Sep 1, 2016 · 9 comments · Fixed by #3067
Closed

Flag messages as spam/ham (not spam) [$15] #23

Quix0r opened this issue Sep 1, 2016 · 9 comments · Fixed by #3067

Comments

@Quix0r
Copy link

Quix0r commented Sep 1, 2016

An easy and common way to move messages to "Junk" folder or from there back to "Inbox" folder.

Original ticket: #15


There is a $15 open bounty on this issue. Add to the bounty at Bountysource.

@jospoortvliet jospoortvliet changed the title Flag messages as spam/ham (not spam) Flag messages as spam/ham (not spam) [$15] Apr 23, 2019
@ChristophWurst ChristophWurst added this to the 1.4.0 milestone May 5, 2020
@ChristophWurst
Copy link
Member

@GretaD possibly something for you to work on?

I think we need these things (can be done in separate PRs)

  1. Visual distinction of spam mails: all emails that have the spam flag should have a distinguishable styling so a user knows to treat the message with caution. I think this is particularly helpful for when the IMAP server flags the message for you but does not move it to a dedicated junk folder. Then the spam messages will still show with your other messages.
  2. Make it possible to mark a message as spam/not spam via the action menu*
  3. Move flagged messages to a dedicated junk/spam mailbox

* interesting enough the IMAP specification has a flag junk and notjunk, so there are three possible states: undefined, junk and not junk. We might want to do a quick research on how other clients handle this.

@GretaD
Copy link
Contributor

GretaD commented May 6, 2020

@GretaD possibly something for you to work on?

I think we need these things (can be done in separate PRs)

  1. Visual distinction of spam mails: all emails that have the spam flag should have a distinguishable styling so a user knows to treat the message with caution. I think this is particularly helpful for when the IMAP server flags the message for you but does not move it to a dedicated junk folder. Then the spam messages will still show with your other messages.

In short, to have another icon smth like this: spam icon after we mark an email as spam? And add more styling except the icon(different color of the text or smth?)?
After we(@nextcloud/designers ) decide for the the icon and other styling, i can start right away with it.

@ChristophWurst
Copy link
Member

Yeah, either an icon or just a different color (lighter font or grey background?) IMO, but I'm not a designer :)

@Bugsbane
Copy link
Member

Bugsbane commented May 6, 2020

I would suggest red text, which suggests not safe, but making it faded as these are not the emails a user would be wanting to read first, so we don't want to give them the strongest visual emphasis.

An icon would help as well. To be honest there doesn't seem to be a universal or even particularly great icon for spam.

Personally I would suggest not going with the exclamation with an octogon around it, as this kind of thing is typically more associated with error messages. If you want to signify either something dangerous or something that you don't want more of, either using the triangle with an exclamation mark icon or a circle with a bar icon respectively.

My preference would be the latter, as the meaning of spam is more email that you don't want, than something dangerous necessarily. Spam can be dangerous, but it isn't always. It is always unwanted.

@jancborchardt
Copy link
Member

jancborchardt commented May 6, 2020

In short, to have another icon smth like this: spam icon after we mark an email as spam? And add more styling except the icon(different color of the text or smth?)?
After we(@nextcloud/designers ) decide for the the icon and other styling, i can start right away with it.

We do have icon-junk which is used for the Junk/Spam folders as icon already, so this is the one we should use as indicator as well. :) It is like icon-error and that is fine, cause it’s warning people to open a message. It could overlay a corner of the avatar (like the "Important" marker). Additionally we could show it in red so it’s more obvious.

@ChristophWurst
Copy link
Member

There is a $15 open bounty on this issue

@GretaD 🤑

@GretaD
Copy link
Contributor

GretaD commented May 13, 2020

There is a $15 open bounty on this issue

@GretaD

First of all we did it together ;)
secondly, the link doesnt work so i guess its not available anymore, but if its still available I'm fine to transfer the amount to another ticket.

@ChristophWurst
Copy link
Member

Just claim it and put it onto another ticket indeed :)

And please send an email to support@bountysource.com about the broken link https://www.bountysource.com/issues/37490538-flag-messages-as-spam-ham-not-spam

For me it returns

{"error":"Internal server error."}

@ChristophWurst
Copy link
Member

Oh wow, their website issues have been going on for two weeks already. And that is not the only time that happened recently https://twitter.com/Bountysource/status/1255733844805734400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants