Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollbars and wasted space in articles #10

Closed
yllar opened this issue Jul 25, 2016 · 4 comments
Closed

scrollbars and wasted space in articles #10

yllar opened this issue Jul 25, 2016 · 4 comments

Comments

@yllar
Copy link

yllar commented Jul 25, 2016

max-width: 770px in content.css under #app-content .body creates unneeded whitespace and scroll bars. On some articles it cuts the embedded YouTube videos and creates scrollbars:
770_before
removing/commenting the line allows content to fill most of the window:
770_after

Windows 10, 1920x1080 display and Chrome 51

@BernhardPosselt
Copy link
Member

Can you post a link to the feed? Will take a look in 2 weeks

@BernhardPosselt
Copy link
Member

In general what should happen is that the video is also limited the width to the article.

Max width should stay at 770px because it's more readable

@yllar
Copy link
Author

yllar commented Jul 25, 2016

screenshot is from http://www.core77.com/home/rss
similar with https://hackaday.com/blog/feed/ (but with this, only small portion of the YouTube/Vimeo video is "cut off")

@BernhardPosselt
Copy link
Member

BernhardPosselt commented Aug 10, 2016

Limitted iframes to 100% width. Your feed sets the width and height for an iframe which is why things are a bit off. The height is now filled with a black border for videos, that's as good as it gets most likely :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants