Fix item lists in CLI #1180
Merged
Fix item lists in CLI #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
fix/cli/item_lists
branch
from
4ef88fe
to
b61073d
Compare
There was a problem hiding this comment.
First test worked well, except for the ''offset'' loading (as discussed here #1172 (comment))
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
fix/cli/item_lists
branch
from
b61073d
to
b2c424d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
============================================
- Coverage 90.88% 87.01% -3.88%
- Complexity 665 687 +22
============================================
Files 57 60 +3
Lines 2371 2473 +102
============================================
- Hits 2155 2152 -3
- Misses 216 321 +105
Continue to review full report at Codecov.
|
SMillerDev
force-pushed
the
fix/cli/item_lists
branch
3 times, most recently
from
2761845
to
df49f37
Compare
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
fix/cli/item_lists
branch
from
df49f37
to
ed3eb6b
Compare
anoymouserver
approved these changes
Feb 20, 2021
Grotax
added a commit
that referenced
this pull request
Feb 23, 2021
Changed - Remove outdated item DB code. ( #1056) - Stop returning all feeds after marking folder as read. (#1056) - Always fetch favicon (#1164) - Use feed logo instead of favicon if it exists and is square (#1164) - Add CI for item lists (#1180) Fixed - Item list throwing error for folder and "all items" (#1180) - Articles with high IDs can be placed lower than articles with low IDs (#1147) - Feeds are accidentally moved on rename (#1189) - Item list not using ID for offset (#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Feb 23, 2021
Changed - Remove outdated item DB code. ( #1056) - Stop returning all feeds after marking folder as read. (#1056) - Always fetch favicon (#1164) - Use feed logo instead of favicon if it exists and is square (#1164) - Add CI for item lists (#1180) Fixed - Item list throwing error for folder and "all items" (#1180) - Articles with high IDs can be placed lower than articles with low IDs (#1147) - Feeds are accidentally moved on rename (#1189) - Item list not using ID for offset (#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves the item list issues.
Fixes #1172