Remove V1 item API #1056
Merged
Remove V1 item API #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
2 times, most recently
from
72d2863
to
ba0e04d
Compare
anoymouserver
requested changes
Jan 18, 2021
There was a problem hiding this comment.
I would recommend implementing the read functions (folder and feed) and purge before we release a new (beta) version. Otherwise there will be issues for not working UI elements or growing databases.
(But you probably already planned to do this. If you need help message me ..)
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
from
ba0e04d
to
d54c129
Compare
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
from
d54c129
to
7e30451
Compare
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
from
7e30451
to
5be9347
Compare
anoymouserver
approved these changes
Jan 19, 2021
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
2 times, most recently
from
5258f00
to
bb3abe2
Compare
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
2 times, most recently
from
815b566
to
1b4940e
Compare
|
Psalm issue would never happen in real life. Not sure how to make it go away though. |
|
Weird that psalm crashes completely with stable20 The unknown classes errors can probably be removed by running |
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
from
1b4940e
to
d468b9e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
=============================================
+ Coverage 69.18% 91.33% +22.15%
+ Complexity 742 662 -80
=============================================
Files 74 57 -17
Lines 2703 2355 -348
=============================================
+ Hits 1870 2151 +281
+ Misses 833 204 -629
Continue to review full report at Codecov.
|
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
chore/disable_v1_item
branch
from
d468b9e
to
633262c
Compare
anoymouserver
added a commit
to anoymouserver/news
that referenced
this pull request
Feb 13, 2021
follow-up for b4fa772 (nextcloud#1056)
anoymouserver
added a commit
to anoymouserver/news
that referenced
this pull request
Feb 13, 2021
follow-up for b4fa772 (nextcloud#1056) Signed-off-by: anoy <anoymouserver+github@mailbox.org>
Grotax
added a commit
that referenced
this pull request
Feb 23, 2021
Changed - Remove outdated item DB code. ( #1056) - Stop returning all feeds after marking folder as read. (#1056) - Always fetch favicon (#1164) - Use feed logo instead of favicon if it exists and is square (#1164) - Add CI for item lists (#1180) Fixed - Item list throwing error for folder and "all items" (#1180) - Articles with high IDs can be placed lower than articles with low IDs (#1147) - Feeds are accidentally moved on rename (#1189) - Item list not using ID for offset (#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Feb 23, 2021
Changed - Remove outdated item DB code. ( #1056) - Stop returning all feeds after marking folder as read. (#1056) - Always fetch favicon (#1164) - Use feed logo instead of favicon if it exists and is square (#1164) - Add CI for item lists (#1180) Fixed - Item list throwing error for folder and "all items" (#1180) - Articles with high IDs can be placed lower than articles with low IDs (#1147) - Feeds are accidentally moved on rename (#1189) - Item list not using ID for offset (#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
follow-up for b4fa772 (nextcloud#1056) Signed-off-by: anoy <anoymouserver+github@mailbox.org> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
follow-up for b4fa772 (nextcloud#1056) Signed-off-by: anoy <anoymouserver+github@mailbox.org> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
follow-up for b4fa772 (nextcloud#1056) Signed-off-by: anoy <anoymouserver+github@mailbox.org> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
3 tasks
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
follow-up for b4fa772 (nextcloud#1056) Signed-off-by: anoy <anoymouserver+github@mailbox.org>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the migration to QBMappers
Signed-off-by: Sean Molenaar sean@seanmolenaar.eu