New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed: Fix rename moving file #1189
Merged
SMillerDev
merged 1 commit into
nextcloud:master
from
SMillerDev:fix/feed/move_on_rename
Feb 23, 2021
Merged
Feed: Fix rename moving file #1189
SMillerDev
merged 1 commit into
nextcloud:master
from
SMillerDev:fix/feed/move_on_rename
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue nextcloud#1181 Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
fix/feed/move_on_rename
branch
from
February 23, 2021 12:31
9ebf8b5
to
a68957b
Compare
anoymouserver
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
However the Integration Tests fail because of the apparently broken nextcloud.com feed. 😄
Grotax
added a commit
that referenced
this pull request
Feb 23, 2021
Changed - Remove outdated item DB code. ( #1056) - Stop returning all feeds after marking folder as read. (#1056) - Always fetch favicon (#1164) - Use feed logo instead of favicon if it exists and is square (#1164) - Add CI for item lists (#1180) Fixed - Item list throwing error for folder and "all items" (#1180) - Articles with high IDs can be placed lower than articles with low IDs (#1147) - Feeds are accidentally moved on rename (#1189) - Item list not using ID for offset (#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Feb 23, 2021
Changed - Remove outdated item DB code. ( #1056) - Stop returning all feeds after marking folder as read. (#1056) - Always fetch favicon (#1164) - Use feed logo instead of favicon if it exists and is square (#1164) - Add CI for item lists (#1180) Fixed - Item list throwing error for folder and "all items" (#1180) - Articles with high IDs can be placed lower than articles with low IDs (#1147) - Feeds are accidentally moved on rename (#1189) - Item list not using ID for offset (#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
3 tasks
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain
pushed a commit
to Team-Forward/news
that referenced
this pull request
Mar 1, 2021
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de> Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Remove outdated item DB code. ( nextcloud#1056) - Stop returning all feeds after marking folder as read. (nextcloud#1056) - Always fetch favicon (nextcloud#1164) - Use feed logo instead of favicon if it exists and is square (nextcloud#1164) - Add CI for item lists (nextcloud#1180) Fixed - Item list throwing error for folder and "all items" (nextcloud#1180) - Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147) - Feeds are accidentally moved on rename (nextcloud#1189) - Item list not using ID for offset (nextcloud#1188) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1181
Signed-off-by: Sean Molenaar sean@seanmolenaar.eu