Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed: Fix rename moving file #1189

Merged
merged 1 commit into from Feb 23, 2021

Conversation

SMillerDev
Copy link
Contributor

Issue #1181

Signed-off-by: Sean Molenaar sean@seanmolenaar.eu

Issue nextcloud#1181

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
@SMillerDev SMillerDev marked this pull request as ready for review February 23, 2021 12:31
Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
However the Integration Tests fail because of the apparently broken nextcloud.com feed. 😄

@SMillerDev SMillerDev merged commit 4e4108a into nextcloud:master Feb 23, 2021
Grotax added a commit that referenced this pull request Feb 23, 2021
Changed
- Remove outdated item DB code. ( #1056)
- Stop returning all feeds after marking folder as read. (#1056)
- Always fetch favicon (#1164)
- Use feed logo instead of favicon if it exists and is square (#1164)
- Add CI for item lists (#1180)

Fixed
- Item list throwing error for folder and "all items" (#1180)
- Articles with high IDs can be placed lower than articles with low IDs (#1147)
- Feeds are accidentally moved on rename (#1189)
- Item list not using ID for offset (#1188)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Feb 23, 2021
Grotax added a commit that referenced this pull request Feb 23, 2021
Changed
- Remove outdated item DB code. ( #1056)
- Stop returning all feeds after marking folder as read. (#1056)
- Always fetch favicon (#1164)
- Use feed logo instead of favicon if it exists and is square (#1164)
- Add CI for item lists (#1180)

Fixed
- Item list throwing error for folder and "all items" (#1180)
- Articles with high IDs can be placed lower than articles with low IDs (#1147)
- Feeds are accidentally moved on rename (#1189)
- Item list not using ID for offset (#1188)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
mnassabain pushed a commit to Team-Forward/news that referenced this pull request Mar 1, 2021
Changed
- Remove outdated item DB code. ( nextcloud#1056)
- Stop returning all feeds after marking folder as read. (nextcloud#1056)
- Always fetch favicon (nextcloud#1164)
- Use feed logo instead of favicon if it exists and is square (nextcloud#1164)
- Add CI for item lists (nextcloud#1180)

Fixed
- Item list throwing error for folder and "all items" (nextcloud#1180)
- Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147)
- Feeds are accidentally moved on rename (nextcloud#1189)
- Item list not using ID for offset (nextcloud#1188)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain pushed a commit to Team-Forward/news that referenced this pull request Mar 1, 2021
Changed
- Remove outdated item DB code. ( nextcloud#1056)
- Stop returning all feeds after marking folder as read. (nextcloud#1056)
- Always fetch favicon (nextcloud#1164)
- Use feed logo instead of favicon if it exists and is square (nextcloud#1164)
- Add CI for item lists (nextcloud#1180)

Fixed
- Item list throwing error for folder and "all items" (nextcloud#1180)
- Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147)
- Feeds are accidentally moved on rename (nextcloud#1189)
- Item list not using ID for offset (nextcloud#1188)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
mnassabain pushed a commit to Team-Forward/news that referenced this pull request Mar 1, 2021
Changed
- Remove outdated item DB code. ( nextcloud#1056)
- Stop returning all feeds after marking folder as read. (nextcloud#1056)
- Always fetch favicon (nextcloud#1164)
- Use feed logo instead of favicon if it exists and is square (nextcloud#1164)
- Add CI for item lists (nextcloud#1180)

Fixed
- Item list throwing error for folder and "all items" (nextcloud#1180)
- Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147)
- Feeds are accidentally moved on rename (nextcloud#1189)
- Item list not using ID for offset (nextcloud#1188)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
Neo11 pushed a commit to Neo11/news that referenced this pull request May 28, 2022
Changed
- Remove outdated item DB code. ( nextcloud#1056)
- Stop returning all feeds after marking folder as read. (nextcloud#1056)
- Always fetch favicon (nextcloud#1164)
- Use feed logo instead of favicon if it exists and is square (nextcloud#1164)
- Add CI for item lists (nextcloud#1180)

Fixed
- Item list throwing error for folder and "all items" (nextcloud#1180)
- Articles with high IDs can be placed lower than articles with low IDs (nextcloud#1147)
- Feeds are accidentally moved on rename (nextcloud#1189)
- Item list not using ID for offset (nextcloud#1188)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants