Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiLine prop #1490

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix multiLine prop #1490

merged 1 commit into from
Oct 19, 2020

Conversation

skjnldsv
Copy link
Contributor

Fix #1483

@skjnldsv
Fix multiLine prop
6ee899e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Oct 19, 2020
@skjnldsv skjnldsv self-assigned this Oct 19, 2020
julien-nc
julien-nc approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@skjnldsv skjnldsv merged commit 6171d6a into master Oct 19, 2020
@skjnldsv skjnldsv deleted the fix/rich-content-multiline branch October 19, 2020 10:09
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@julien-nc julien-nc julien-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GretaD GretaD Awaiting requested review from GretaD

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency between "multiLine" and "multiline"
3 participants
@skjnldsv @julien-nc @danxuliu