fix: Add a webpackrule to resolve module js files in node_modules
#3754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Pytal
approved these changes
Feb 14, 2023
raimund-schluessler
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
@susnux Awesome, thanks a lot! The local styleguide build works again.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run styleguidebroken #3753This should probably go into the webpack config project, but until it is fixed there, we should fix it here.
Somewhere in a module js (ESM) file, probably by webpack-node-polyfills,
process/browserwithout the required.jsextension is imported. We do not use babel-loader on the node_modules and the default loader defaults toresolveFullySpecified = true, so this causes an issue. See also https://webpack.js.org/configuration/module/#resolvefullyspecified