Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focused select border color with top placement #3782

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Fix focused select border color with top placement #3782

merged 1 commit into from
Feb 19, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Feb 18, 2023

Before After
image image

@Pytal
Fix focused select border color with top placement
5c0fad5 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Feb 18, 2023
@Pytal Pytal added this to the 7.7.0 milestone Feb 18, 2023
@Pytal Pytal self-assigned this Feb 18, 2023
@raimund-schluessler raimund-schluessler merged commit e435c05 into master Feb 19, 2023
@raimund-schluessler raimund-schluessler deleted the fix/a11y-select-border branch February 19, 2023 14:33
@szaimen szaimen mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@susnux susnux susnux approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @susnux @raimund-schluessler