fix: Catch exceptions thrown by NotificationMail constructor #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when constructor would throw, it would stop there and on the next run the notifications before the broken one would get resent. Exceptions from constructor are now caught and the process continues. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
dartcafe
approved these changes
Jul 11, 2024
|
Related to #3607? |
|
/backport to next |
|
@dartcafe Any change to get it merged and released as 7.1.x / 7.1.4? Thanks in advance |
I guess in some way. The effect is that it retries this every 5 minutes and spams with mail notifications. |
|
I am just waiting for the merge and plan to release after it. @come-nc Do you expect me to merge or do you prefer to merge it by yourself? I am fine with both approaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when constructor would throw, it would stop there and on the
next run the notifications before the broken one would get resent.
Exceptions from constructor are now caught and the process continues.