Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Server Colors not in sync #748

Closed
5 of 8 tasks
AndyXheli opened this issue Feb 29, 2024 · 8 comments · Fixed by #747
Closed
5 of 8 tasks

[Bug]: Server Colors not in sync #748

AndyXheli opened this issue Feb 29, 2024 · 8 comments · Fixed by #747
Assignees
Labels
3. to review bug Something isn't working

Comments

@AndyXheli
Copy link

AndyXheli commented Feb 29, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Looks like the folder colors are all in sync the color i set should be like the color in the outlook folder but everything is folwoing the other darker color

image

Steps to reproduce

Change Server color to #0082C9 not everything is showing up as #0082C9

Expected behavior

Everything should be in #0082C9

Installation method

Community Manual installation with Archive

Nextcloud Server version

28.0.3

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@AndyXheli AndyXheli added 0. Needs triage bug Something isn't working labels Feb 29, 2024
@AndyXheli AndyXheli changed the title [Bug]: Folder Colors not in sync [Bug]: Server Colors not in sync Feb 29, 2024
@susnux
Copy link
Contributor

susnux commented Mar 1, 2024

If you set up a color as primary, then that color is not guranteed to be used as it is. Due to accessibility restrictions that color might be slightly adjusted to fulfill the color contrasts requirements.

Meaning when setting the default color of #0082C9 then you will get #0091f2 on the bright color theme for elements (e.g. those primary buttons).

@susnux
Copy link
Contributor

susnux commented Mar 1, 2024

The reason for this is the mime type icons returned by OC.MimeType. Primary colors are not adjusted to the correct used colors.

@skjnldsv
Copy link
Member

The reason for this is the mime type icons returned by OC.MimeType. Primary colors are not adjusted to the correct used colors.

That's a fix for the recommendation app, no?

@mvvvmd
Copy link

mvvvmd commented May 24, 2024

I think this will resolve the issue of inconsistently: nextcloud/server#45163

@AndyXheli
Copy link
Author

Still an issue on NC 29.0.1

@susnux
Copy link
Contributor

susnux commented May 29, 2024

I think the issue is IconBuilder::colorSvg that calls elementColor without background color so the color might be different to the color used for buttons.
Problem here is that we do not know if it has dark theme or bright theme.

@skjnldsv
Copy link
Member

#747

@skjnldsv skjnldsv transferred this issue from nextcloud/server May 30, 2024
@skjnldsv skjnldsv self-assigned this May 30, 2024
@AndyXheli
Copy link
Author

#747

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants