Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Note to recipient" API #11270

Closed
tobiasKaminsky opened this issue Sep 18, 2018 · 8 comments
Closed

"Note to recipient" API #11270

tobiasKaminsky opened this issue Sep 18, 2018 · 8 comments

Comments

@tobiasKaminsky
Copy link
Member

This was introduced in NC14.
Ideally when such features are developed, where clients may benefit from, please also ping the client teams.

Now the question, how can I add this into client? Are there already public API/endpoints?

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #3923 (Preview API), #4159 (Shared API ), #5282 (Provide Calendar API), #885 (Public Theming API), and #3617 (Setting Favorite API).

@weeman1337
Copy link
Member

@tobiasKaminsky you mean the file sharing, right?
Just send the note request data. Could you please try if that works for you?

image
image

@weeman1337
Copy link
Member

I opened some PRs to get it into the documentation.

There is a changelog for developers: https://nextcloud.com/blog/changes-for-developers-in-nextcloud-14-beta-4-ready-for-testing/

But it's missing the share note info :(
@rullzer is it possible to add it afterwards?

@tobiasKaminsky
Copy link
Member Author

@weeman1337 thank you for the hint.

This is a sample curl to put a note to a share:

curl --request PUT \
  --url 'https://server.com/nextcloud/ocs/v2.php/apps/files_sharing/api/v1/shares/624?note=%22test123%22' \
  --header 'authorization: Basic 123==' \
  --header 'ocs-apirequest: true'

@tobiasKaminsky
Copy link
Member Author

@weeman1337 for me this issue can be closed.
Can you maybe link the PR for documentation here and then close the issue.

@weeman1337
Copy link
Member

@tobiasKaminsky the documentation PRs are linked above.
When they're merged they will close this issue here.

@tobiasKaminsky
Copy link
Member Author

Ah, cool, I totally overlooked the links by Github, but looked only at your written text. 👍

@rullzer
Copy link
Member

rullzer commented Sep 25, 2018

Docs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants