-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC15 bug, client does not work for users which have shared files from deleted LDAP users #15161
Comments
Tried to find some mapping issues in the database, but didn't find anything suspicous: |
Okay, I finally found the issue (using phpMyAdmin to make whole searches of the offending GUIDs in database). As it happens, when the oc_share table contains a share from a non existing GUID (in my case, a deleted LDAP account), the upper reported error appears and the sync client cannot work anymore, and a lot of messages spam the nextcloud log. Once I executed the following statement, everything worked fine again (where XX guid is existing user and YY guid is deleted user as in the above logs):
Fearing of updating other NC instances that have deleted users which shared content. Best regards. |
I got this problem for every user which has shared files / folders from disabled / non-existent accounts. |
I can reproduce this issue on Nextcloud 15.0.8 when we removed an user from the group used in Nextcloud's LDAP filter who was sharing files with another user. It also causes these files to continuously show in the Nextcloud web client as if shared "just now" with a size of 0kb. I've anonymized the below logs: When temporarily readding the account to the group for testing, the sync client worked again. If an user gets disabled but remains in the group, Nextcloud correctly sees them as disabled and this bug isn't triggered.
|
Good to know it can be reproduced :) Thanks for your insight. |
Any news ? IMHO this seems to be a blocker for everyone having LDAP accounts. |
This bug still exists on v15.0.12... Please consider a workaround or a fix. |
Hello,
I updated my Nextcloud 13.0.4 instance to 14 and then to 15.0.7.
Everything worked smootly, except for a couple of LDAP users. The user can login via web, but cannot use the Nextcloud client (v2.5.1 Windows 10 x64).
Everytime the user logs in or try to sync via the client, I get an error message in the nextcloud log, that shows the "user" property with a GUID (which is valid, tested via occ user, and maps to the user it should), and a message showing another GUID (which exists but is a deleted user).
Somehow, Nextcloud gives a wrong GUID as argument to getHome, even when "user" property is the right GUID in the request. Both GUIDs exist in oc_ldap_user_mapping (and map to the right corresponding DN).
Btw, willing to do debug work, mysql queries etc in order to find what is wrong.
Here are the logs (changed valid GUID to XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX) and deleted user GUID to YYYYYYYY-YYYY-YYYY-YYYY-YYYYYYYYYYYY).
Steps to reproduce
Expected behaviour
I guess there should be only one GUID in the error message.
The args for function getHome is another GUID.
Server configuration
Operating system: CentOS 7 x64 1810 uptodate
Web server: Apache 2.4.6-88
Database: MariaDB 5.5.60-1
PHP version: PHP 7.1.8-1
Nextcloud version: 15.0.7
Updated from an older Nextcloud/ownCloud or fresh install: Updated from 13.0.4 to 14 latest then to 15.0.7
Where did you install Nextcloud from: (via web update)
List of activated apps:
App list
Nextcloud configuration:
Config report
Are you using external storage, if yes which one: No
Are you using encryption: No
Are you using an external user-backend, if yes which one: LDAP
LDAP configuration (delete this part if not used)
LDAP config
Client configuration
Browser: Opera 58.0.3135.127
Operating system: Windows 10 x64 1810
Logs
Web server error log
No webserver errors, only standard logs
Nextcloud log (data/nextcloud.log)
Nextcloud log
Please find log JSFormatted above.Browser log
Browser log
Not relevant.Client log
Client log
``` [OCC::SyncEngine::startSync #### Discovery start #################################################### [OCC::SyncEngine::startSync Server "15.0.7.0" [csync_update ## Starting local discovery ## [_csync_detect_update ._sync_459682522672.db excluded (1) [_csync_detect_update ._sync_459682522672.db-shm excluded (1) [_csync_detect_update ._sync_459682522672.db-wal excluded (1) [_csync_detect_update Desktop.ini excluded (1) [csync_ftw <= Closing walk for C:/Users/User/Nextcloud2 with read_from_db 0 [csync_update Update detection for local replica took 0 seconds walking 0 files [csync_update ## Starting remote discovery ## [OCC::AccessManager::createRequest 6 "PROPFIND" "https://some.vhost.local/remote.php/dav/files/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/" has X-Request-ID "299c710e-dd76-4432-99a1-6fdb3d3d14eb" [OCC::AbstractNetworkJob::start OCC::LsColJob created for "https://some.vhost.local" + "" "OCC::DiscoverySingleDirectoryJob" [OCC::WebFlowCredentials::slotFinished request finished [OCC::WebFlowCredentials::stillValid Still valid? [OCC::WebFlowCredentials::stillValid QNetworkReply::NetworkError(NoError) [OCC::WebFlowCredentials::stillValid "Erreur inconnue" [OCC::JsonApiJob::finished JsonApiJob of QUrl("https://some.vhost.local/ocs/v2.php/apps/notifications/api/v2/notifications?format=json") FINISHED WITH STATUS "OK" [OCC::JsonApiJob::finished Nothing changed so nothing to retrieve - status code: 304 [OCC::ServerNotificationHandler::slotNotificationsReceived Status code 304 Not Modified - No new notifications. [OCC::WebFlowCredentials::slotFinished request finished [OCC::WebFlowCredentials::stillValid Still valid? [OCC::WebFlowCredentials::stillValid QNetworkReply::NetworkError(NoError) [OCC::WebFlowCredentials::stillValid "Erreur inconnue" [OCC::LsColJob::finished LSCOL of QUrl("https://some.vhost.local/remote.php/dav/files/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/") FINISHED WITH STATUS "OK" [OCC::DiscoverySingleDirectoryJob::directoryListingIteratedSlot Missing properties: "0-- Hébergement --0" 2 0 1555594867 "DNVS" "" "-0000001ocbsqudz0nu2" [csync_ftw opendir failed for - errno 10011 [OCC::SyncEngine::handleSyncError ERROR during csync_update : "Une erreur de transmission HTTP s'est produite. Données manquantes dans la réponse à la découverte du fichier sur le serveur " [OCC::ActivityWidget::addError Item "Nextcloud2" retrieved resulted in "Une erreur de transmission HTTP s'est produite. Données manquantes dans la réponse à la découverte du fichier sur le serveur " [OCC::ActivityListModel::addErrorToActivityList Error successfully added to the notification list: "Une erreur de transmission HTTP s'est produite. Données manquantes dans la réponse à la découverte du fichier sur le serveur " [OCC::SyncJournalDb::close Closing DB "C:/Users/User/Nextcloud2/._sync_459682522672.db" [OCC::SyncEngine::finalize CSync run took 505 ms [OCC::Folder::slotSyncFinished Client version 2.5.1final (build 20181204) Qt 5.11.1 SSL OpenSSL 1.0.1h 5 Jun 2014 [OCC::Folder::slotSyncFinished SyncEngine finished with ERROR [OCC::Folder::showSyncResultPopup Folder sync result: 2 [OCC::Folder::slotSyncFinished the last 4 syncs failed [OCC::SocketListener::sendMessage Sending SocketAPI message --> "UPDATE_VIEW:C:\\Users\\User\\Nextcloud2" to QLocalSocket(0x1d34da1eca0) [OCC::SocketListener::sendMessage Sending SocketAPI message --> "UPDATE_VIEW:C:\\Users\\User\\Nextcloud2" to QLocalSocket(0x1d34da1ea60) [OCC::SocketListener::sendMessage Sending SocketAPI message --> "UPDATE_VIEW:C:\\Users\\User\\Nextcloud2" to QLocalSocket(0x1d34da1eb40) [OCC::ownCloudGui::slotSyncStateChange Sync state changed for folder "https://some.vhost.local/remote.php/dav/files/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/" : "Error" [OCC::FolderMan::slotFolderSyncFinished <========== Sync finished for folder [Nextcloud2] of account [XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX@some.vhost.local] with remote [https://some.vhost.local/remote.php/dav/files/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/] ```The text was updated successfully, but these errors were encountered: