Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Limit to groups" changes setting for all apps, not just the selected #20685

Open
RogoTe opened this issue Apr 4, 2020 · 7 comments
Open

"Limit to groups" changes setting for all apps, not just the selected #20685

RogoTe opened this issue Apr 4, 2020 · 7 comments
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback 29-feedback bug feature: apps management good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@RogoTe
Copy link

RogoTe commented Apr 4, 2020

I tried to use the "Limit to groups" settings to disable some apps for a certain user group, when I stumbled upon the following bug: everytime I check or uncheck this field for one app, the same setting is applied to all other apps as well. The list of groups is not affected, it behaves like expected.
Not shure if this issue belongs here or to nextcloud/server.

Details

  • Browser and browser version: Firefox 74.0.1 and Safari 13.1 on MacOS 10.15.4

JavaScript Console Output

marked(): sanitize and sanitizer parameters are deprecated since version 0.7.0, should not be used and will be removed in the future. Read more here: https://marked.js.org/#/USING_ADVANCED.md#options vue-7.js:1:23339

Steps to reproduce

  1. Log in to Nextcloud as Administrator, go to Apps
  2. select one of the installed apps, e.g. Calendar
  3. Check whether "Limit to groups" is checked
  4. Select another app, e.g. Tasks
  5. Click "Limit to groups" to change the setting
  6. Go back to first app (Calendar) --> you will see the setting for "Limit to groups" changed according to the second app
@mario
Copy link
Contributor

mario commented Apr 27, 2020

I'll move this to server as I think it belongs there.

@mario mario transferred this issue from nextcloud/appstore Apr 27, 2020
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Aug 20, 2020
@Rello
Copy link
Contributor

Rello commented Mar 1, 2021

I can confirm this.
As far as I can see its a display issue. whatever setting you see first (see an app with/without), this is also shown on all others.
THe checked setting is not reinitialized when selecting another app

@szaimen
Copy link
Contributor

szaimen commented Jun 23, 2021

This is just a display error which becomes clear after you reload the side but it should be fixed nonetheless.

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. feature: apps management enhancement and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 23, 2021
@nroach44
Copy link

This still seems to be occurring in 26.0.3.

@Rello
Copy link
Contributor

Rello commented Jul 18, 2023

@szaimen I think the issue is that one:

this.groupCheckedAppsData = true

this.groupCheckedAppsData is set on the initial load of the app list (mounted())
this is then always true for all apps and being checked here.

https://github.com/nextcloud/server/blob/master/apps/settings/src/mixins/AppManagement.js#L81

could this be the issue?

@szaimen
Copy link
Contributor

szaimen commented Jul 18, 2023

Yes, looks like it. cc @nextcloud/server-frontend

@szaimen szaimen added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix. labels Jul 18, 2023
@joshtrichards joshtrichards added bug 27-feedback and removed enhancement design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. labels Sep 11, 2023
@joshtrichards
Copy link
Member

Reproduced in v27.0.2.

Nearly, but not quite the same as #16069 (likely very similar fixes).

Cosmetic only (confirmed by checking actual config via occ config:list <app>), but this report reflects the behavior in NC27 accurately while #16069 reflects behavior in NC25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback 29-feedback bug feature: apps management good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

7 participants