-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing activity for favorites via WebDAV #26393
Comments
It is webdav. So I consider this a core app. I'd be fine to call an internal function. Long term we should move it all to DAV and kill the dedicatd endpoint IMO |
Yep, but then we can also copy it over now and then just deprecate the old method :) Nothing lost and avoided unnecessary complexity that we need to reduce in the future again. |
Fine by me :) |
The web UI uses
apps/files/api/v1/files/FILE
API that does trigger the activity.The code to add the tag:
server/apps/files/lib/Service/TagService.php
Lines 85 to 112 in d89a75b
And then the actitivity:
server/apps/files/lib/Service/TagService.php
Lines 119 to 148 in d89a75b
While the PROPPATCH doesn't trigger anything related to that:
server/apps/dav/lib/Connector/Sabre/TagsPlugin.php
Lines 284 to 295 in eb502c0
How to handle this? The ugly way by making tthe method in
TagService
public and call from the dav app directly into the files app to have it all in one place, or to copy it over and deprecated the files app approach as we should go for DAV based API access anyways? I would say option 2.cc @rullzer @ChristophWurst @kesselb @PVince81 @juliushaertl
The text was updated successfully, but these errors were encountered: