Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mixed translations in sharing details #40825

Merged
merged 1 commit into from Oct 9, 2023

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Oct 9, 2023

Due to a typo in the app passed to the translation method, some strings translations don't work.

This commit corrects the spelling file_sharing to files_sharing and hence resolves : #40801

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Oct 9, 2023

/backport to stable27

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Could we somehow add a workflow that checks this? I saw this happening quite often in the past...

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Oct 9, 2023

/compile amend /

Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS force-pushed the 40801-fix-mixed-translation-sharing branch from 9444547 to 10675f7 Compare October 9, 2023 16:40
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Oct 9, 2023

/compile amend /

@Fenn-CS Fenn-CS enabled auto-merge October 9, 2023 16:40
@Fenn-CS Fenn-CS merged commit e1db6dc into master Oct 9, 2023
40 checks passed
@Fenn-CS Fenn-CS deleted the 40801-fix-mixed-translation-sharing branch October 9, 2023 18:05
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Translation mixed content in the new share menu since v27.1.1
3 participants